This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
Base-64 encode answer code. #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vihan <contact@vihan.org>
Mego
approved these changes
Apr 23, 2018
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 70.39% 70.41% +0.01%
==========================================
Files 62 62
Lines 1503 1504 +1
Branches 127 127
==========================================
+ Hits 1058 1059 +1
Misses 401 401
Partials 44 44 |
Mego
added a commit
that referenced
this pull request
May 7, 2018
* rename to Axtell everywhere * Add comment frontend (#112) * Add comment frontend Signed-off-by: Vihan <contact@vihan.org> * fix tests * Add comments Signed-off-by: Vihan <contact@vihan.org> * Add comment frontend Signed-off-by: Vihan <contact@vihan.org> * fix tests * Add comments Signed-off-by: Vihan <contact@vihan.org> * Bug fixes and tweaks Signed-off-by: Vihan <contact@vihan.org> * Add relative timestamps. Signed-off-by: Vihan <contact@vihan.org> * Remove testing from debug. This resulted in incorrect builds since we want production assets to be generated. Signed-off-by: Vihan <contact@vihan.org> * Name updates Signed-off-by: Vihan <contact@vihan.org> * Fix header margins Signed-off-by: Vihan <contact@vihan.org> * Remove broken test Signed-off-by: Vihan <contact@vihan.org> * Add post comments Signed-off-by: Vihan <contact@vihan.org> * Hide "write comment" if not logged in. Signed-off-by: Vihan <contact@vihan.org> * Base-64 encode answer code. (#123) Signed-off-by: Vihan <contact@vihan.org> * Add UTF8 buffer (#124) Signed-off-by: Vihan <contact@vihan.org> * Add feedback button to resources (#125) Signed-off-by: Vihan <contact@vihan.org> * Redo answer sorting + add timestamps (#126) Signed-off-by: Vihan <contact@vihan.org> * Add a small "Unanswered" indicator on post list. (#127) This helps quickly see which challenges don't have answers. Potentially later this will be changed to be below the title and include more numbers that provide challenge stats. Signed-off-by: Vihan <contact@vihan.org> * Create new CSS files (#128) Signed-off-by: Vihan <contact@vihan.org> * Add nice indicators when voting for own post (#129) * Add nice indicators when voting for own post Signed-off-by: Vihan <contact@vihan.org> * Also just add the strikethrough fix here Signed-off-by: Vihan <contact@vihan.org> * Update .coveragerc * Rollbar and WebAssets (#131) * Add Rollbar basic support Signed-off-by: Vihan <contact@vihan.org> * Move away from WebAssets and Rollbar integration. WebAssets was problematic so this moves to Parcel (css) and Webpack (js) and also adds integration with Rollbar API. Webpack allows us to get sourcemaps which we can provide Rollbar which has been added in travis setup. Signed-off-by: Vihan <contact@vihan.org> * Remove old WebAssets code Signed-off-by: Vihan <contact@vihan.org> * Add Rollbar deploy tracking Signed-off-by: Vihan <contact@vihan.org> * Streamline error and user management. Error & user management now together use Data fields rather than AJAX requests. Additionally this means Auth is now sync for pre-auth'd pages so that simplifies things. This also makes it so Rollbar errors pass user information and instance ids for debugging Signed-off-by: Vihan <contact@vihan.org> * Theme bug fix and ErrorManager#warn Adds the warn method to ErrorManager and also fixes themes for unauthorized users in the fact that it now will default to light. Signed-off-by: Vihan <contact@vihan.org> * Add "see more" to comments (#130) Signed-off-by: Vihan <contact@vihan.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should result incorrect byte-counting for code that wouldn't be as newlines are encoded as 2-bytes since HTTP form encoding converts LF to CRLF
Fixes #122
Signed-off-by: Vihan contact@vihan.org