Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile #24

Merged
merged 3 commits into from
Apr 30, 2022
Merged

Add Dockerfile #24

merged 3 commits into from
Apr 30, 2022

Conversation

jcalonso
Copy link
Contributor

Add a simple Dockerfile to allow people running JsonVisio using Docker.
Later this Dockerfile could be used in a GitHub action to provide and official Docker image.

Add a simple Dockerfile to allow people running using Docker.
Later this Dockerfile could be used in a GitHub action to provide
and official Docker image.
Copy link
Contributor

@mg6 mg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely with the fix, thanks!

README.md Outdated Show resolved Hide resolved
Co-authored-by: Maciej Gamrat <maciej@gamrat.it>
@jcalonso
Copy link
Contributor Author

Thanks for the review 🙂
Added your fix 👍🏼

Copy link
Contributor

@mg6 mg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@AykutSarac AykutSarac merged commit 80e0a8c into AykutSarac:main Apr 30, 2022
@AykutSarac
Copy link
Owner

Thanks for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants