Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import file by drag and drop #284

Merged
merged 2 commits into from
Jan 21, 2023
Merged

import file by drag and drop #284

merged 2 commits into from
Jan 21, 2023

Conversation

liqun98
Copy link
Contributor

@liqun98 liqun98 commented Jan 1, 2023

Add a feature that import file by drag and drop.

2023-01-01.19.34.00.mov

Solve the issue #283

@liqun98 liqun98 mentioned this pull request Jan 1, 2023
Closed
@AykutSarac
Copy link
Owner

Thanks for the PR, we should check the file type and decline if the file extension is not ".json".

@liqun98
Copy link
Contributor Author

liqun98 commented Jan 2, 2023

Add a file check and toast when the file type is not JSON.Please review it when you have some time.

@AykutSarac AykutSarac added the enhancement Improve performance or optimization label Jan 12, 2023
@AykutSarac AykutSarac merged commit b8a86b1 into AykutSarac:main Jan 21, 2023
@TallTed
Copy link
Contributor

TallTed commented Jan 23, 2023

JSON-LD (application/ld+json, .jsonld) file is subclass of JSON (application/json, .json) file... and should also be accepted, wherever JSON file is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improve performance or optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liqun98 @AykutSarac @TallTed