Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Share Link #40

Merged
merged 5 commits into from
Jul 17, 2022
Merged

Add Share Link #40

merged 5 commits into from
Jul 17, 2022

Conversation

victorbrambati
Copy link
Contributor

I see this Issues #28 then I implemented a share link transforming json in base64 for use in url.

@AykutSarac
Copy link
Owner

The link is extremely long, we should find a way to make it shorter. Best way is seems to be connect the link with URL shortener service and display the user shortened link. Thanks for your contribution, I'll keep it open for now!

@victorbrambati
Copy link
Contributor Author

The link is extremely long, we should find a way to make it shorter. Best way is seems to be connect the link with URL shortener service and display the user shortened link. Thanks for your contribution, I'll keep it open for now!

It is a good idea, but I searched for a lot shortner service and I didn't find a free service that fits this project. I thought of another way, for create a link minify the json and encode on base64 and for read the link beautify the json and decode the base64. It has cut by nearly half the size of link.

@AykutSarac AykutSarac added the feature Feature request or suggestion label Jun 9, 2022
@AykutSarac
Copy link
Owner

Thanks for the PR. However we cannot implement it as there are conditions such as the file size could be very big and the link could be so long thus it'd lead to further issues. Instead I'm planning to connect it to a backend to save JSON & generate links, that way we could also implement website embeds as well.

Closing the PR, thanks for the insights!

@AykutSarac AykutSarac closed this Jun 17, 2022
@AykutSarac AykutSarac reopened this Jul 17, 2022
@AykutSarac
Copy link
Owner

Thanks for your contribution, after making appropriate changes matching with the main branch I'm merging your PR!

@AykutSarac AykutSarac merged commit 0d6a9ad into AykutSarac:main Jul 17, 2022
@AykutSarac AykutSarac linked an issue Jul 17, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request or suggestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share link
2 participants