Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: sometimes codemirror is not working properly at first time opening in browser #20

Closed
AyloSrd opened this issue Jun 27, 2022 · 4 comments · Fixed by #41
Closed

Bug: sometimes codemirror is not working properly at first time opening in browser #20

AyloSrd opened this issue Jun 27, 2022 · 4 comments · Fixed by #41
Labels
bug Something isn't working

Comments

@AyloSrd
Copy link
Owner

AyloSrd commented Jun 27, 2022

When opening reactplayground from a link for the first time in a browser, codemirror is showing a black page for App.js, we need either refresh the page, or open another codeMirror page in the text editor, for it to re-start working.

Couldn't identify the cause of such malfunction.
@AyloSrd AyloSrd added the bug Something isn't working label Jun 27, 2022
This was referenced Jul 29, 2022
Closed
Closed
@AyloSrd
Copy link
Owner Author

AyloSrd commented Jul 29, 2022 •
edited
Loading

I suspect the problem comes from the gutter width which grows to 700+px, at div.codemirror-gutter-elt maybe giving a specific max-width would work

@AyloSrd
Copy link
Owner Author

AyloSrd commented Aug 4, 2022

probaly is margin-left of .CodeMirror-sizer

AyloSrd added a commit that referenced this issue Aug 5, 2022
@AyloSrd
Merge pull request #33 from AyloSrd/RP-trying-to-fix-issue-#20
b83fc49 
attempt to fix issue #20
@AyloSrd
Copy link
Owner Author

AyloSrd commented Aug 6, 2022

It's probably working now, this worked, jsut waiting some time to be sure, before removing the issue. Still considering changing lib for CodeMirror component

@AyloSrd AyloSrd linked a pull request Aug 26, 2022 that will close this issue
Rp change code mirror library first attempt #41
Merged
@AyloSrd
Copy link
Owner Author

AyloSrd commented Aug 26, 2022

#41 should have fixed it

@AyloSrd AyloSrd closed this as completed Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rp change code mirror library first attempt AyloSrd/reactplayground
1 participant
@AyloSrd