Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text align and Italic #8

Closed
rosostolato opened this issue Aug 29, 2019 · 9 comments
Closed

Text align and Italic #8

rosostolato opened this issue Aug 29, 2019 · 9 comments

Comments

@rosostolato
Copy link

rosostolato commented Aug 29, 2019

It does not handle text-align style and <em> tag:

< p style="text-align: center;"> <span style="font-size: 14px;"><em><strong>testing...</strong></em></span> < /p>

result:

{ "text":"testing...", "bold":true, "style":["html-strong","html-em","html-span","html-p"] }

@rosostolato rosostolato changed the title Text align Text align and Italic Aug 29, 2019
@Aymkdn Aymkdn closed this as completed in aeb3148 Aug 29, 2019
@Aymkdn Aymkdn reopened this Aug 29, 2019
@Aymkdn
Copy link
Owner

Aymkdn commented Aug 29, 2019

I've fixed it in v1.0.6 ... it was actually an issue with nested/cascaded tags.

@Aymkdn Aymkdn closed this as completed Aug 29, 2019
@rosostolato
Copy link
Author

rosostolato commented Aug 29, 2019

That's right... Thank you for your fast answer!

@SunnysideAaron
Copy link

SunnysideAaron commented Sep 11, 2019

I work with @rosostolato and just tried the new fix. when a word is both bold and italic the word still disappears. Lists don't appear to be fixed either. We are trying to use the vue2-editor package for our front end and html-to-pdfmake to generate pdfs.

I've confirmed we are on v1.0.6 of html-to-pdfmake
input string:
<p>i am <strong>a <em>sentence,</em> see</strong> me <u>roar</u>.</p><p><br></p><ul><li>I'm first list</li><li>first list 2nd item</li></ul><p><br></p><p>new sentence no list</p><p><br></p><ol><li>i'm a list</li><li class="ql-indent-1">I'm sub list</li></ol><p><br></p>

in UI:
Screen Shot 2019-09-11 at 10 57 17 AM

generated pdf:
Screen Shot 2019-09-11 at 10 57 41 AM

@Aymkdn
Copy link
Owner

Aymkdn commented Sep 11, 2019

I'll look at this on Saturday. I don't have the time before the weekend... Sorry, guys.

@SunnysideAaron
Copy link

no worries. thanks for working on it.

Aymkdn added a commit that referenced this issue Sep 14, 2019
- Fixed issue #7
- Fixed issue #8
- Fixed issue #10
- Fixed issue #11
@Aymkdn
Copy link
Owner

Aymkdn commented Sep 14, 2019

That should be resolved with v1.0.7

@SunnysideAaron
Copy link

the italic and bold inside each other now appears fixed. But lists are not displaying at all.

@Aymkdn
Copy link
Owner

Aymkdn commented Sep 17, 2019

Examples?

@SunnysideAaron
Copy link

SunnysideAaron commented Sep 17, 2019

<p>Here I am.</p><p><br></p><p>I'm another sentence two lines down. <s>Some strike through.</s></p><p><br></p><ul><li>list item 1</li><li class="ql-indent-1">list item 1.2</li><li>list item 2</li></ul><p><br></p><p><br></p>

this produces
Screen Shot 2019-09-17 at 2 18 23 PM

Here is the same output in our UI's text field which uses the vue2-editor package

Screen Shot 2019-09-17 at 2 19 50 PM

There are 3 problems:
No strike through
2nd sentence is on line 2 instead of line 3.
Lists aren't displayed at all.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants