Not display agents with allow_public_data:false on public organizatio…

…n page
AyuntamientoMadrid · Jan 26, 2018 · 7d258e3 · 7d258e3
1 parent 5a33bdb
commit 7d258e3
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 12 deletions.
diff --git a/app/views/organizations/show.html.erb b/app/views/organizations/show.html.erb
@@ -276,19 +276,21 @@
         <div class="content active">
           <% if @organization.agents.present? %>
             <% @organization.agents.each do |agent| %>
-              <p>
-                <strong><%= t('organizations.show.agents_fullname') %></strong>
-                <%= agent.name %>
-                <%= agent.first_surname %>
-                <%= agent.second_surname %>
-              </p>
-              <p><strong><%= t('organizations.show.agents_from') %></strong>
-                <%= I18n.l agent.from if agent.from? %>
-              </p>
-              <% if agent.to.present? %>
-                <p><strong><%= t('organizations.show.agents_to') %></strong>
-                  <%= I18n.l agent.to if agent.to.present? %>
+              <% if agent.allow_public_data %>
+                <p>
+                  <strong><%= t('organizations.show.agents_fullname') %></strong>
+                  <%= agent.name %>
+                  <%= agent.first_surname %>
+                  <%= agent.second_surname %>
+                </p>
+                <p><strong><%= t('organizations.show.agents_from') %></strong>
+                  <%= I18n.l agent.from if agent.from? %>
                 </p>
+                <% if agent.to.present? %>
+                  <p><strong><%= t('organizations.show.agents_to') %></strong>
+                    <%= I18n.l agent.to if agent.to.present? %>
+                  </p>
+                <% end %>
               <% end %>
             <% end %>
           <% else %>

diff --git a/spec/features/organizations_spec.rb b/spec/features/organizations_spec.rb
@@ -607,6 +607,17 @@
       expect(page).to have_content I18n.l(agent2.to)
     end
 
+    scenario "Should not display organization agent info allow_public_data: false" do
+      organization = create(:organization)
+      agent1 = create(:agent, organization: organization, to: Date.current, allow_public_data: true)
+      agent2 = create(:agent, organization: organization, to: Date.current, allow_public_data: false)
+
+      visit organization_path(organization)
+
+      expect(page).to have_content agent1.name
+      expect(page).not_to have_content agent2.name
+    end
+
     scenario "Should display canceled organization but not display agent info" do
       organization = create(:organization, canceled_at: Date.current)
       agent = create(:agent, organization: organization)