Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom callback in VCS #269

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Allow custom callback in VCS #269

merged 1 commit into from
Oct 5, 2022

Conversation

alfespa17
Copy link
Member

Adding a new field inside VCS connections to allow a custom callback instead of using the VCS id, this will allow to define the callback from the UI when need it.

POST {{terrakubeApi}}/api/v1/organization/{{organizationId}}/vcs
{
  "data": {
    "type": "vcs",
    "attributes": {
      "name": "vcsGitHubCustom",
      "description": "vcsGitHubDescription",
      "vcsType": "GITHUB",
      "clientId": "{{githubClientId}}",
      "clientSecret": "{{githubClientSecret}}",
      "callback": "{{githubCallback}}"
    }
  }
}

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@alfespa17 alfespa17 merged commit f7c1791 into main Oct 5, 2022
@alfespa17 alfespa17 deleted the custom-callback branch October 5, 2022 23:55
@alfespa17 alfespa17 linked an issue Oct 5, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Callback url improvement
1 participant