Remove the internal crypto algorithm enum that has to be maintained #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The algorithms are already downloaded from Apple, so just use this as the master list instead of keeping another internal lookup key list.
|
Thank you for pull request. I'm off till Monday. I will review the code on Tuesday afternoon or Wednesday |
|
@necsord maybe you will find a while to review the pull request earlier than me? |
|
Cool. Certainly no rush for it on my side. Whenever you're ready 👍 |
hywak
reviewed
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The algorithms are already downloaded from Apple, so just use this as the master list instead of keeping another internal lookup key list.
PHP isn't my main language, so if I've done something stupid..sorry..
I've tested this in my app, and it's working fine. Also ran the unit tests and updated the failing ones.