Skip to content

Commit

Permalink
chore: pin foundry (#5151)
Browse files Browse the repository at this point in the history
I tried increasing gas limit of anvil and disabling it altogether
(--disable-block-gas-limit flag) but it didn't help. In `forge` there is
a `--memory-limit` which is supposed to directly affect this value but
this flag is not exposed on anvil. What is weird that the issue occurs
when running "empty block" test case in
`integration_l1_publisher.test.ts` but it doesn't occur for the bloated
one. This makes me think that it probably really is some kind of bug and
not just a gas limit issue.

What is also weird is that for a [version from 4 days
ago](https://github.com/foundry-rs/foundry/releases/tag/nightly-9ec42d6f03bafbd3b9bb8e258ca67d7887b1f2e7)
I was getting the error as well. I would not expect this given that the
issue started occurring yesterday. I [asked on Foundry support
channel](https://t.me/foundry_support/51173) and hopefully we will get
some feedback.

In the meanwhile I found a version for which all seems to work so I
would merge this PR to not waste too much time on this. We can just
revert it in the future.
  • Loading branch information
benesjan committed Mar 12, 2024
1 parent a74dccb commit 69bd7dd
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 8 deletions.
3 changes: 2 additions & 1 deletion barretenberg/sol/scripts/install_foundry.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ FOUNDRY_BIN_DIR="$FOUNDRY_DIR/bin"
BIN_URL="https://raw.githubusercontent.com/foundry-rs/foundry/master/foundryup/foundryup"
BIN_PATH="$FOUNDRY_BIN_DIR/foundryup"
FOUNDRY_MAN_DIR="$FOUNDRY_DIR/share/man/man1"
FOUNDRY_VERSION="nightly-de33b6af53005037b463318d2628b5cfcaf39916"

# Clean
rm -rf $FOUNDRY_DIR
Expand All @@ -18,4 +19,4 @@ chmod +x $BIN_PATH
export PATH=$FOUNDRY_BIN_DIR:$PATH

# Use version.
foundryup
foundryup --version $FOUNDRY_VERSION
3 changes: 2 additions & 1 deletion iac/mainnet-fork/scripts/install_foundry.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ FOUNDRY_BIN_DIR="$FOUNDRY_DIR/bin"
BIN_URL="https://raw.githubusercontent.com/foundry-rs/foundry/master/foundryup/foundryup"
BIN_PATH="$FOUNDRY_BIN_DIR/foundryup"
FOUNDRY_MAN_DIR="$FOUNDRY_DIR/share/man/man1"
FOUNDRY_VERSION="nightly-de33b6af53005037b463318d2628b5cfcaf39916"

# Clean
rm -rf $FOUNDRY_DIR
Expand All @@ -18,4 +19,4 @@ chmod +x $BIN_PATH
export PATH=$FOUNDRY_BIN_DIR:$PATH

# Use version.
foundryup
foundryup --version $FOUNDRY_VERSION
3 changes: 2 additions & 1 deletion l1-contracts/scripts/install_foundry.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ FOUNDRY_BIN_DIR="$FOUNDRY_DIR/bin"
BIN_URL="https://raw.githubusercontent.com/foundry-rs/foundry/master/foundryup/foundryup"
BIN_PATH="$FOUNDRY_BIN_DIR/foundryup"
FOUNDRY_MAN_DIR="$FOUNDRY_DIR/share/man/man1"
FOUNDRY_VERSION="nightly-de33b6af53005037b463318d2628b5cfcaf39916"

# Clean
rm -rf $FOUNDRY_DIR
Expand All @@ -18,4 +19,4 @@ chmod +x $BIN_PATH
export PATH=$FOUNDRY_BIN_DIR:$PATH

# Use version.
foundryup
foundryup --version $FOUNDRY_VERSION
2 changes: 1 addition & 1 deletion yarn-project/aztec/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: '3'
services:
ethereum:
image: ghcr.io/foundry-rs/foundry@sha256:29ba6e34379e79c342ec02d437beb7929c9e254261e8032b17e187be71a2609f
image: ghcr.io/foundry-rs/foundry:nightly-de33b6af53005037b463318d2628b5cfcaf39916
entrypoint: >
sh -c '
if [ -n "$FORK_BLOCK_NUMBER" ] && [ -n "$FORK_URL" ]; then
Expand Down
2 changes: 1 addition & 1 deletion yarn-project/end-to-end/scripts/docker-compose-anvil.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: '3'
services:
fork:
image: ghcr.io/foundry-rs/foundry:nightly-a44aa13cfc23491ba32aaedc093e9488c1a6db43
image: ghcr.io/foundry-rs/foundry:nightly-de33b6af53005037b463318d2628b5cfcaf39916
entrypoint: 'anvil -p 8545 --host 0.0.0.0 --chain-id 31337'
ports:
- '8545:8545'
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: '3'
services:
fork:
image: ghcr.io/foundry-rs/foundry:nightly-a44aa13cfc23491ba32aaedc093e9488c1a6db43
image: ghcr.io/foundry-rs/foundry:nightly-de33b6af53005037b463318d2628b5cfcaf39916
entrypoint: >
sh -c '
if [ -n "$FORK_BLOCK_NUMBER" ] && [ -n "$FORK_URL" ]; then
Expand Down
2 changes: 1 addition & 1 deletion yarn-project/end-to-end/scripts/docker-compose-p2p.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: '3'
services:
fork:
image: ghcr.io/foundry-rs/foundry:nightly-a44aa13cfc23491ba32aaedc093e9488c1a6db43
image: ghcr.io/foundry-rs/foundry:nightly-de33b6af53005037b463318d2628b5cfcaf39916
entrypoint: 'anvil -p 8545 --host 0.0.0.0 --chain-id 31337'
ports:
- '8545:8545'
Expand Down
2 changes: 1 addition & 1 deletion yarn-project/end-to-end/scripts/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: '3'
services:
fork:
image: ghcr.io/foundry-rs/foundry:nightly-a44aa13cfc23491ba32aaedc093e9488c1a6db43
image: ghcr.io/foundry-rs/foundry:nightly-de33b6af53005037b463318d2628b5cfcaf39916
entrypoint: >
sh -c '
if [ -n "$FORK_BLOCK_NUMBER" ] && [ -n "$FORK_URL" ]; then
Expand Down

0 comments on commit 69bd7dd

Please sign in to comment.