Skip to content

Commit

Permalink
chore: remove temporary logging (#3466)
Browse files Browse the repository at this point in the history
The 2 pixies test have not failed since I fixed [this race
condition](9557a66)
last week so I think we can be pretty confident that it was really the
case of the failures. For this reason I am removing the temporary
logging here.
  • Loading branch information
benesjan committed Nov 29, 2023
1 parent 051dda9 commit 8c8387b
Showing 1 changed file with 2 additions and 29 deletions.
31 changes: 2 additions & 29 deletions yarn-project/aztec.js/src/contract/sent_tx.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { FieldsOf, MAX_NEW_NULLIFIERS_PER_TX } from '@aztec/circuits.js';
import { FieldsOf } from '@aztec/circuits.js';
import { retryUntil } from '@aztec/foundation/retry';
import { ExtendedNote, GetUnencryptedLogsResponse, PXE, TxHash, TxReceipt, TxStatus } from '@aztec/types';

Expand Down Expand Up @@ -66,34 +66,7 @@ export class SentTx {
}
const receipt = await this.waitForReceipt(opts);
if (receipt.status !== TxStatus.MINED) {
// ############## Temporary code start ##############
// A few logs placed here temporarily to help me (@benesjan) debug an issue with intermittent failure of
// 2 pixies test.
// https://github.com/AztecProtocol/aztec-packages/issues/3357
// For whatever reason (according to logs) the tx which appears here as dropped seems to be correctly included
// in a block and the block built and submitted on-chain. I will try to fetch the latest block here and see
// which txs it contains to check if the block source used here has the relevant block. If it doesn't then
// the test is probably misconfigured and an incorrect block source is used (pxe pointing to a different aztec
// node or smt like that) or there is some bigger issue with block sync somewhere.
const blockNum = await this.pxe.getBlockNumber();
const block = await this.pxe.getBlock(blockNum);
if (block) {
const txHashes = [];
for (let txIndex = 0; txIndex < block!.numberOfTxs; txIndex++) {
const txHash = block!.newNullifiers[MAX_NEW_NULLIFIERS_PER_TX * txIndex];
txHashes.push(txHash.toString());
}
throw new Error(
`Transaction ${await this.getTxHash()} was ${
receipt.status
}.\nTx hashes of txs included in the last synced block ${block?.number} are: ${txHashes}`,
);
} else {
throw new Error(`Transaction ${await this.getTxHash()} was ${receipt.status}. Block ${blockNum} not found.`);
}
// ############## Temporary code end ##############

// throw new Error(`Transaction ${await this.getTxHash()} was ${receipt.status}`);
throw new Error(`Transaction ${await this.getTxHash()} was ${receipt.status}`);
}
if (opts?.debug) {
const txHash = await this.getTxHash();
Expand Down

0 comments on commit 8c8387b

Please sign in to comment.