fix: address comments and format

AztecProtocol · May 10, 2024 · d657fda · d657fda
1 parent d1855d3
commit d657fda
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/noir-projects/noir-contracts/contracts/avm_test_contract/src/main.nr b/noir-projects/noir-contracts/contracts/avm_test_contract/src/main.nr
@@ -342,8 +342,8 @@ contract AvmTest {
     }
 
     #[aztec(public-vm)]
-    fn to_radix_le(input: Field ) -> [u8; 10] {
-        let result: [u8] =input.to_le_radix(2, 10);
+    fn to_radix_le(input: Field) -> [u8; 10] {
+        let result: [u8] = input.to_le_radix(/*base=*/ 2, /*limbs=*/ 10);
         result.as_array()
     }
 }
diff --git a/yarn-project/simulator/src/avm/avm_simulator.test.ts b/yarn-project/simulator/src/avm/avm_simulator.test.ts
@@ -879,6 +879,7 @@ describe('AVM simulator: transpiled Noir contracts', () => {
       expect(results.revertReason?.message).toEqual('Assertion failed: Values are not equal');
     });
   });
+
   it('conversions', async () => {
     const calldata: Fr[] = [new Fr(0b1011101010100)];
     const context = initContext({ env: initExecutionEnvironment({ calldata }) });
@@ -887,10 +888,10 @@ describe('AVM simulator: transpiled Noir contracts', () => {
     const results = await new AvmSimulator(context).executeBytecode(bytecode);
 
     expect(results.reverted).toBe(false);
-    const expectedResults = '1011101010100'.split('').reverse().slice(0, 10).map(Number);
-    for (let i = 0; i < 10; i++) {
-      expect(results.output[i]).toEqual(new Fr(expectedResults[i]));
-    }
+    const expectedResults = Buffer.concat('0010101011'.split('').map(c => new Fr(Number(c)).toBuffer()));
+    const resultBuffer = Buffer.concat(results.output.map(f => f.toBuffer()));
+
+    expect(resultBuffer.equals(expectedResults)).toBe(true);
   });
 });