Skip to content

Commit

Permalink
fix: e2e getStack, disable failing e2e (#5768)
Browse files Browse the repository at this point in the history
Some of these were failing. Barring a fix, marking flakey
  • Loading branch information
ludamad committed Apr 16, 2024
1 parent b2d9b9d commit e5f3ece
Show file tree
Hide file tree
Showing 10 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/ci-setup-action/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,5 @@ runs:
echo "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" > "/run/${{ inputs.concurrency_key }}.lock"
echo "/run/${{ inputs.concurrency_key }}.lock acquired."
post: |
rm "/run/${{ inputs.concurrency_key }}.lock"
rm "/run/${{ inputs.concurrency_key }}.lock" || true
echo "/run/${{ inputs.concurrency_key }}.lock removed."
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ jobs:
timeout-minutes: 40
run: earthly ./yarn-project+export-end-to-end
# We base our e2e list used in e2e-x86 off the targets in ./yarn-project/end-to-end
# (Note ARM uses just 2 tests as a smoketest)
- name: Create list of end-to-end jobs
id: e2e_list
run: echo "list=$(earthly ls ./yarn-project/end-to-end | grep -v '+base' | sed 's/+//' | jq -R . | jq -cs .)" >> $GITHUB_OUTPUT
Expand Down
6 changes: 4 additions & 2 deletions yarn-project/circuit-types/src/simulation_error.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ export class SimulationError extends Error {
options?: ErrorOptions,
) {
super(originalMessage, options);
const getMessage = () => this.getMessage();
const getStack = () => this.getStack();
Object.defineProperties(this, {
message: {
configurable: false,
Expand All @@ -82,7 +84,7 @@ export class SimulationError extends Error {
* @returns The message.
*/
get() {
return this.getMessage();
return getMessage();
},
},
stack: {
Expand All @@ -93,7 +95,7 @@ export class SimulationError extends Error {
* @returns The stack.
*/
get() {
return this.getStack();
return getStack();
},
},
});
Expand Down

0 comments on commit e5f3ece

Please sign in to comment.