Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine type serialization properties into one export #3756

Closed
critesjosh opened this issue Dec 20, 2023 · 1 comment · Fixed by #4135
Closed

Combine type serialization properties into one export #3756

critesjosh opened this issue Dec 20, 2023 · 1 comment · Fixed by #4135
Assignees
Labels
devex Improving developer experience sandbox-feedback

Comments

@critesjosh
Copy link
Contributor

Consider adding SERIALIZED_LEN to the TypeSerializationInterface to make the imports in contracts less verbose.

For example,

global FIELD_SERIALIZED_LEN: Field = 1;

could be added to

global FieldSerializationMethods = TypeSerializationInterface {
    deserialize: deserializeField,
    serialize: serializeField,
};

@Maddiaa0 correct me if I'm wrong, but this was my takeaway from the call.

@critesjosh critesjosh added devex Improving developer experience sandbox-feedback labels Dec 20, 2023
@rahul-kothari
Copy link
Contributor

Am hoping that Traits removes the need for this altogether!

Thunkar added a commit that referenced this issue Jan 30, 2024
Closes: #3756,
#2838


Taking advantage of @jfecher's fantastic work in
noir-lang/noir#4000, implemented `Serialize<N>`
and `Deserialize<N>`. Together with `NoteInterface`, they make possible
getting rid of all the serialization interfaces, which greatly simplify
how the storage is handled and opens the door to further improvements.
~~Still some clutter to go, the lengths are still needed in some
places.~~


![Brace yourself](https://i.imgflip.com/8crkve.jpg)

I'm so sorry.

---------

Co-authored-by: sirasistant <sirasistant@gmail.com>
AztecBot pushed a commit to AztecProtocol/aztec-nr that referenced this issue Jan 31, 2024
Closes: AztecProtocol/aztec-packages#3756,
AztecProtocol/aztec-packages#2838


Taking advantage of @jfecher's fantastic work in
noir-lang/noir#4000, implemented `Serialize<N>`
and `Deserialize<N>`. Together with `NoteInterface`, they make possible
getting rid of all the serialization interfaces, which greatly simplify
how the storage is handled and opens the door to further improvements.
~~Still some clutter to go, the lengths are still needed in some
places.~~


![Brace yourself](https://i.imgflip.com/8crkve.jpg)

I'm so sorry.

---------

Co-authored-by: sirasistant <sirasistant@gmail.com>
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
…ocol#4135)

Closes: AztecProtocol#3756,
AztecProtocol#2838


Taking advantage of @jfecher's fantastic work in
noir-lang/noir#4000, implemented `Serialize<N>`
and `Deserialize<N>`. Together with `NoteInterface`, they make possible
getting rid of all the serialization interfaces, which greatly simplify
how the storage is handled and opens the door to further improvements.
~~Still some clutter to go, the lengths are still needed in some
places.~~


![Brace yourself](https://i.imgflip.com/8crkve.jpg)

I'm so sorry.

---------

Co-authored-by: sirasistant <sirasistant@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devex Improving developer experience sandbox-feedback
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants