Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Misc): Expose the storage layout at the contract artifact level #5947

Closed
Tracked by #5070
LHerskind opened this issue Apr 23, 2024 · 0 comments · Fixed by #5952
Closed
Tracked by #5070

feat(Misc): Expose the storage layout at the contract artifact level #5947

LHerskind opened this issue Apr 23, 2024 · 0 comments · Fixed by #5952

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Apr 23, 2024

Expose the storage layout on the ContractArtifact such that it can easily be accessed

LHerskind added a commit that referenced this issue Apr 24, 2024
Fixes #5947 and includes the notes as well. The notes was part of the
contract object, but not directly exposed on the artifact itself.

Needed to fix a few additional things to make it work:
- The `deploy_contract` function was broken (old call flow), it cannot
do the new flow because that would be a circular dependency.
- Using the `storageLayout` values to get the `storageSlot` that we are
using in multiple tests
- Using the `notes` values to get the `noteTypeId` that we are using in
multiple tests
- Removed `lodash.uniqby` as the dependency was not needed after this.
TomAFrench pushed a commit that referenced this issue Apr 24, 2024
Fixes #5947 and includes the notes as well. The notes was part of the
contract object, but not directly exposed on the artifact itself.

Needed to fix a few additional things to make it work:
- The `deploy_contract` function was broken (old call flow), it cannot
do the new flow because that would be a circular dependency.
- Using the `storageLayout` values to get the `storageSlot` that we are
using in multiple tests
- Using the `notes` values to get the `noteTypeId` that we are using in
multiple tests
- Removed `lodash.uniqby` as the dependency was not needed after this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant