Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update noir subrepo and fix breaking changes #3729

Merged
merged 13 commits into from
Dec 19, 2023

Conversation

sirasistant
Copy link
Contributor

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@AztecBot
Copy link
Collaborator

AztecBot commented Dec 18, 2023

Benchmark results

Metrics with a significant change:

  • note_history_trial_decrypting_time_in_ms (10): 343 (+50%)
  • note_trial_decrypting_time_in_ms (8): 18.7 (-59%)
  • note_trial_decrypting_time_in_ms (32): 53.7 (-47%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 6877ca1c and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,960 868,208 3,449,732
l1_rollup_execution_gas 842,047 3,595,316 22,205,101
l2_block_processing_time_in_ms 2,217 (-8%) 8,446 (-3%) 35,205 (-1%)
note_successful_decrypting_time_in_ms 309 (-8%) 928 (-5%) 3,357 (-4%)
note_trial_decrypting_time_in_ms ⚠️ 18.7 (-59%) ⚠️ 53.7 (-47%) 198 (-1%)
l2_block_building_time_in_ms 20,205 80,286 (-1%) 322,638 (-1%)
l2_block_rollup_simulation_time_in_ms 16,683 66,316 (-1%) 266,245 (-1%)
l2_block_public_tx_process_time_in_ms 3,492 (-2%) 13,900 (-1%) 56,143

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 24,805 47,299 (-1%)
note_history_successful_decrypting_time_in_ms 2,182 (-1%) 4,213
note_history_trial_decrypting_time_in_ms 162 (-1%) ⚠️ 343 (+50%)
node_database_size_in_bytes 3,618,936 3,912,569
pxe_database_size_in_bytes 29,748 59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 200 43,109 20,441
private-kernel-ordering 115 25,833 9,689
base-rollup 2,976 667,692 873
root-rollup 85.5 (-1%) 4,072 881
private-kernel-inner 261 64,516 20,441
public-kernel-private-input 172 25,203 20,441
public-kernel-non-first-iteration 171 (+1%) 25,245 20,441
merge-rollup 9.29 (-15%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 10,323 25,883

@sirasistant sirasistant changed the title Arv/update subrepo noir wasm feat: Update noir subrepo and fix breaking changes Dec 19, 2023
subrepo:
  subdir:   "noir"
  merged:   "bb048714e"
upstream:
  origin:   "https://github.com/noir-lang/noir"
  branch:   "aztec-packages"
  commit:   "d78841474"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"
@sirasistant sirasistant marked this pull request as ready for review December 19, 2023 11:28
@sirasistant sirasistant merged commit 3be3546 into gj/noir-wasm-refactor Dec 19, 2023
82 checks passed
@sirasistant sirasistant deleted the arv/update_subrepo_noir_wasm branch December 19, 2023 11:29
@vezenovm vezenovm mentioned this pull request Dec 19, 2023
4 tasks
vezenovm added a commit that referenced this pull request Dec 19, 2023
This is a recreation of this PR
(#3528) to handle PR
#3729

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
AztecBot pushed a commit to noir-lang/noir that referenced this pull request Dec 19, 2023
This is a recreation of this PR
(AztecProtocol/aztec-packages#3528) to handle PR
AztecProtocol/aztec-packages#3729

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this pull request Dec 31, 2023
This is a recreation of this PR
(AztecProtocol/aztec-packages#3528) to handle PR
AztecProtocol/aztec-packages#3729

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
sirasistant pushed a commit to noir-lang/noir that referenced this pull request Jan 4, 2024
This is a recreation of this PR
(AztecProtocol/aztec-packages#3528) to handle PR
AztecProtocol/aztec-packages#3729

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Maddiaa0 pushed a commit that referenced this pull request Jan 8, 2024
This is a recreation of this PR
(#3528) to handle PR
#3729

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
michaelelliot pushed a commit to Swoir/noir_rs that referenced this pull request Feb 28, 2024
This is a recreation of this PR
(AztecProtocol#3528) to handle PR
AztecProtocol#3729

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants