Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add bit size to const opcode #4385

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Conversation

sirasistant
Copy link
Contributor

@sirasistant sirasistant commented Feb 2, 2024

No description provided.

Copy link
Contributor

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hyped about this!

@AztecBot
Copy link
Collaborator

AztecBot commented Feb 2, 2024

Benchmark results

Metrics with a significant change:

  • note_history_trial_decrypting_time_in_ms (5): 245 (+160%)
  • note_trial_decrypting_time_in_ms (8): 109 (+569%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 8569e7c0 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,636 180,516 720,036
l1_rollup_calldata_gas 222,540 870,732 3,465,528
l1_rollup_execution_gas 315,027 988,472 3,685,185
l2_block_processing_time_in_ms 1,155 (+1%) 4,358 (-1%) 17,225
note_successful_decrypting_time_in_ms 300 (-1%) 960 (-1%) 3,610
note_trial_decrypting_time_in_ms ⚠️ 109 (+569%) 92.1 (-8%) 141 (+1%)
l2_block_building_time_in_ms 17,665 70,071 281,947
l2_block_rollup_simulation_time_in_ms 13,022 51,567 208,174
l2_block_public_tx_process_time_in_ms 4,618 18,373 73,527

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 13,757 (-1%) 26,174 (-1%)
note_history_successful_decrypting_time_in_ms 2,330 (-3%) 4,725 (-1%)
note_history_trial_decrypting_time_in_ms ⚠️ 245 (+160%) 232 (+30%)
node_database_size_in_bytes 17,334,352 33,087,568
pxe_database_size_in_bytes 29,923 59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 310 44,481 26,193
private-kernel-ordering 193 44,513 14,929
base-rollup 1,404 128,970 881
root-rollup 82.1 4,088 677
private-kernel-inner 414 71,640 26,193
public-kernel-private-input 239 32,615 26,193
public-kernel-non-first-iteration 238 32,657 26,193
merge-rollup 7.59 2,608 881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 2 leaves 8 leaves 16 leaves 32 leaves 128 leaves 64 leaves 512 leaves 1024 leaves 2048 leaves 8192 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.2 10.6 (-5%) 12.5 (-5%) 17.1 (+2%) 23.3 (+2%) 63.6 (-1%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.9 17.5 23.0 31.6 47.0 143 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.595 0.592 (-5%) 0.536 (-4%) 0.532 (+2%) 0.488 (+2%) 0.439 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A N/A N/A N/A 74.5 47.4 238 459 899 3,549
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A N/A N/A N/A 159 96.0 543 1,055 2,079 8,223
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A N/A N/A N/A 0.459 0.487 0.435 0.431 0.428 0.427
batch_insert_into_indexed_tree_20_depth_ms N/A N/A N/A N/A N/A 103 56.5 349 685 1,367 (-1%) 5,408
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A N/A N/A N/A 197 104 691 1,363 2,707 10,771
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A N/A N/A N/A 0.490 0.495 0.473 (-1%) 0.472 0.473 0.471
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A 56.4 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A 94.1 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A 0.577 N/A N/A N/A N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 15,575 38,271 (+1%)

Transaction processing duration by data writes.

Metric 0 new commitments 1 new commitments
tx_pxe_processing_time_ms 546 1,219
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms 0.509 (-18%) 570

@sirasistant sirasistant enabled auto-merge (squash) February 5, 2024 11:43
Copy link
Contributor

@LeilaWang LeilaWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sirasistant sirasistant merged commit b2a000e into master Feb 5, 2024
85 checks passed
@sirasistant sirasistant deleted the arv/const_opcode_bit_size branch February 5, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants