Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Rangecheck with consistent bit size #4556

Closed
wants to merge 1 commit into from

Conversation

sirasistant
Copy link
Contributor

Please read contributing guidelines and remove this line.

@AztecBot
Copy link
Collaborator

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 3063bf32 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,956 181,604 724,196
l1_rollup_calldata_gas 227,108 888,764 3,535,976
l1_rollup_execution_gas 320,299 1,007,212 3,756,354
l2_block_processing_time_in_ms 1,171 (+1%) 4,674 (+7%) 17,292
note_successful_decrypting_time_in_ms 315 1,037 (+7%) 3,650 (+2%)
note_trial_decrypting_time_in_ms 23.9 (-2%) 42.7 (-56%) 145 (-3%)
l2_block_building_time_in_ms 18,216 72,299 (+1%) 289,727
l2_block_rollup_simulation_time_in_ms 13,485 53,537 215,098
l2_block_public_tx_process_time_in_ms 4,699 (+1%) 18,685 (+1%) 74,372 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,790 (+2%) 28,898 (+5%)
note_history_successful_decrypting_time_in_ms 2,353 4,754 (+4%)
note_history_trial_decrypting_time_in_ms 92.0 (-7%) 162 (-31%)
node_database_size_in_bytes 17,272,912 33,157,200
pxe_database_size_in_bytes 29,923 59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 330 (+1%) 44,528 25,313
private-kernel-ordering 197 (+1%) 43,633 16,193
base-rollup 1,458 129,774 933
root-rollup 91.0 (+10%) 4,192 729
private-kernel-inner 439 (+1%) 70,819 25,313
public-kernel-private-input 240 33,663 26,945
public-kernel-non-first-iteration 240 (+1%) 33,705 26,945
merge-rollup 8.02 (+2%) 2,712 933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 2 leaves 8 leaves 16 leaves 32 leaves 128 leaves 64 leaves 512 leaves 1024 leaves 2048 leaves 8192 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.2 10.6 (-10%) 12.9 (+2%) 17.2 (+2%) 28.6 (+26%) 64.2 (+1%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.9 17.5 23.0 31.6 47.0 143 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.594 (-1%) 0.594 (-10%) 0.548 (+2%) 0.532 (+1%) 0.600 (+26%) 0.442 (+1%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A N/A N/A N/A 74.7 (-1%) 47.6 (-1%) 240 463 902 3,562
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A N/A N/A N/A 159 96.0 543 1,055 2,079 8,223
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A N/A N/A N/A 0.462 (-1%) 0.488 (-1%) 0.437 0.434 0.429 0.428
batch_insert_into_indexed_tree_20_depth_ms N/A N/A N/A N/A N/A 104 (+1%) 57.0 354 (-1%) 688 1,372 5,433
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A N/A N/A N/A 197 104 691 1,363 2,707 10,771
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A N/A N/A N/A 0.492 0.499 0.477 (-2%) 0.473 0.476 0.472
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A 56.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A 94.1 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A 0.578 N/A N/A N/A N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 16,859 39,794

Transaction processing duration by data writes.

Metric 0 new commitments 1 new commitments
tx_pxe_processing_time_ms 556 1,450
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms 0.524 577 (+1%)

github-merge-queue bot pushed a commit to noir-lang/noir that referenced this pull request Feb 13, 2024
# Description

## Problem\*

Partial work towards #4275

## Summary\*



## Additional Context

Tested in aztec-packages here
AztecProtocol/aztec-packages#4556

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants