Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Check initialization arguments in constructors #5144

Merged
merged 13 commits into from
Mar 13, 2024
Merged

feat: Check initialization arguments in constructors #5144

merged 13 commits into from
Mar 13, 2024

Commits on Mar 13, 2024

  1. feat: Check init args match address preimage 

    The responsibility to check that the initialization arguments used
when calling the initializer as correct is responsibility of the
initializer itself. Without this check, a deployer could commit to a set
of init args in the address preimage, but then call the initializer
using something totally different.
    @spalladino
    spalladino committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    fd16529 View commit details
    Browse the repository at this point in the history

  2. Enable the check for all initializers

    @spalladino
    spalladino committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    0fcade3 View commit details
    Browse the repository at this point in the history

  3. Format

    @spalladino
    spalladino committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    84be5c4 View commit details
    Browse the repository at this point in the history

  4. Descriptive errors for typed oracle missing functions

    @spalladino
    spalladino committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    3e041c8 View commit details
    Browse the repository at this point in the history

  5. Fix simulator test

    @spalladino
    spalladino committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    03ef986 View commit details
    Browse the repository at this point in the history

  6. Use toHumanReadable when printing logs in sample dapp

    @spalladino
    spalladino committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    02df977 View commit details
    Browse the repository at this point in the history

  7. Allow alternative constructor name in getContractInstanceFromDeployPa… 

    …rams
    @spalladino
    spalladino committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    dfa1974 View commit details
    Browse the repository at this point in the history

  8. Add getContractInstance public oracle call

    @spalladino
    spalladino committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    7549ba1 View commit details
    Browse the repository at this point in the history

  9. Oops

    @spalladino
    spalladino committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    c64e4f1 View commit details
    Browse the repository at this point in the history

  10. Lint

    @spalladino
    spalladino committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    37b4af3 View commit details
    Browse the repository at this point in the history

  11. Add comment in getContractInstance public oracle implementation

    @spalladino
    spalladino committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    90a4f3c View commit details
    Browse the repository at this point in the history

  12. Fix and refactor e2e deploy tests

    @spalladino
    spalladino committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    235d22d View commit details
    Browse the repository at this point in the history

  13. Update noir-projects/aztec-nr/aztec/src/initializer.nr 

    Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com>
    @spalladino @alexghr
    spalladino and alexghr committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ecfead7 View commit details
    Browse the repository at this point in the history