Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase the json limit for RPC requests #5161

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

PhilWindle
Copy link
Collaborator

This PR increases the json rpc payload size limit.

@PhilWindle PhilWindle enabled auto-merge (squash) March 12, 2024 15:54
@PhilWindle PhilWindle merged commit 419958c into master Mar 12, 2024
94 of 95 checks passed
@PhilWindle PhilWindle deleted the pw/increase-json-limit branch March 12, 2024 16:10
@AztecBot
Copy link
Collaborator

Benchmark results

Metrics with a significant change:

  • note_successful_decrypting_time_in_ms (8): 221 (+58%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 5457edb3 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 5,668 18,820 36,356
l1_rollup_calldata_gas 65,956 238,768 469,292
l1_rollup_execution_gas 666,588 953,629 1,336,600
l2_block_processing_time_in_ms 1,305 (-1%) 4,785 (+1%) 8,927
note_successful_decrypting_time_in_ms ⚠️ 221 (+58%) 581 (+6%) 988 (-3%)
note_trial_decrypting_time_in_ms 29.3 (-37%) 95.7 (+50%) 120 (+57%)
l2_block_building_time_in_ms 11,982 47,787 95,791 (-2%)
l2_block_rollup_simulation_time_in_ms 6,977 28,075 (+1%) 56,378 (-2%)
l2_block_public_tx_process_time_in_ms 4,982 19,655 39,299 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,162 (-2%) 26,786 (-3%)
note_history_successful_decrypting_time_in_ms 1,467 (+13%) 2,483 (-4%)
note_history_trial_decrypting_time_in_ms 112 (-3%) 185 (+24%)
node_database_size_in_bytes 19,079,248 35,905,616 (+1%)
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 277 (+1%) 44,338 27,700
private-kernel-ordering 207 (-1%) 52,324 14,326
base-rollup 634 (-1%) 177,083 925
root-rollup 68.1 (-1%) 4,176 789
private-kernel-inner 360 (-2%) 73,197 27,700
public-kernel-app-logic 179 (-1%) 34,582 27,671
public-kernel-tail 91.6 (-1%) 34,206 27,671
merge-rollup 8.30 2,696 925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 9.97 15.9 (-3%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.582 0.491 (-3%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 46.5 (-3%) 71.5 (-4%) 229 443 (-2%) 863 1,715 N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.478 (-3%) 0.442 (-4%) 0.419 0.415 (-2%) 0.411 0.412 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 53.5 (-3%) 106 336 661 (-1%) 1,314 (+1%) 2,606 N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 104 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.477 (-2%) 0.479 0.456 0.456 0.454 0.453 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 61.1 (-2%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.535 (-2%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes
tx_size_in_bytes 22,014

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes
tx_pxe_processing_time_ms 3,059 1,441 (-1%)
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms 14.0 613 (-1%)

TomAFrench added a commit that referenced this pull request Mar 12, 2024
* master:
  feat: Nullifier non membership (#5152)
  refactor: share code between provers (#4655)
  fix: Increase the json limit for RPC requests (#5161)
  fix: Move timers for ClientIVC breakdown (#5145)
  chore(master): Release 0.27.0 (#5100)
critesjosh pushed a commit that referenced this pull request Mar 12, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.27.1</summary>

##
[0.27.1](aztec-package-v0.27.0...aztec-package-v0.27.1)
(2024-03-12)


### Miscellaneous

* **aztec-package:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg.js: 0.27.1</summary>

##
[0.27.1](barretenberg.js-v0.27.0...barretenberg.js-v0.27.1)
(2024-03-12)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-cli: 0.27.1</summary>

##
[0.27.1](aztec-cli-v0.27.0...aztec-cli-v0.27.1)
(2024-03-12)


### Miscellaneous

* **aztec-cli:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.27.1</summary>

##
[0.27.1](aztec-packages-v0.27.0...aztec-packages-v0.27.1)
(2024-03-12)


### Features

* Further ClientIVC breakdown
([#5146](#5146))
([c8e1cb8](c8e1cb8))
* Nullifier non membership
([#5152](#5152))
([426bd6d](426bd6d))


### Bug Fixes

* Increase the json limit for RPC requests
([#5161](#5161))
([419958c](419958c))
* Move timers for ClientIVC breakdown
([#5145](#5145))
([5457edb](5457edb))


### Miscellaneous

* **boxes:** Adding clone contract option
([#4980](#4980))
([a427aa5](a427aa5))
* Share code between provers
([#4655](#4655))
([ef10d65](ef10d65))
</details>

<details><summary>barretenberg: 0.27.1</summary>

##
[0.27.1](barretenberg-v0.27.0...barretenberg-v0.27.1)
(2024-03-12)


### Features

* Further ClientIVC breakdown
([#5146](#5146))
([c8e1cb8](c8e1cb8))


### Bug Fixes

* Move timers for ClientIVC breakdown
([#5145](#5145))
([5457edb](5457edb))


### Miscellaneous

* Share code between provers
([#4655](#4655))
([ef10d65](ef10d65))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Mar 13, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.27.1</summary>

##
[0.27.1](AztecProtocol/aztec-packages@aztec-package-v0.27.0...aztec-package-v0.27.1)
(2024-03-12)


### Miscellaneous

* **aztec-package:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg.js: 0.27.1</summary>

##
[0.27.1](AztecProtocol/aztec-packages@barretenberg.js-v0.27.0...barretenberg.js-v0.27.1)
(2024-03-12)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-cli: 0.27.1</summary>

##
[0.27.1](AztecProtocol/aztec-packages@aztec-cli-v0.27.0...aztec-cli-v0.27.1)
(2024-03-12)


### Miscellaneous

* **aztec-cli:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.27.1</summary>

##
[0.27.1](AztecProtocol/aztec-packages@aztec-packages-v0.27.0...aztec-packages-v0.27.1)
(2024-03-12)


### Features

* Further ClientIVC breakdown
([#5146](AztecProtocol/aztec-packages#5146))
([c8e1cb8](AztecProtocol/aztec-packages@c8e1cb8))
* Nullifier non membership
([#5152](AztecProtocol/aztec-packages#5152))
([426bd6d](AztecProtocol/aztec-packages@426bd6d))


### Bug Fixes

* Increase the json limit for RPC requests
([#5161](AztecProtocol/aztec-packages#5161))
([419958c](AztecProtocol/aztec-packages@419958c))
* Move timers for ClientIVC breakdown
([#5145](AztecProtocol/aztec-packages#5145))
([5457edb](AztecProtocol/aztec-packages@5457edb))


### Miscellaneous

* **boxes:** Adding clone contract option
([#4980](AztecProtocol/aztec-packages#4980))
([a427aa5](AztecProtocol/aztec-packages@a427aa5))
* Share code between provers
([#4655](AztecProtocol/aztec-packages#4655))
([ef10d65](AztecProtocol/aztec-packages@ef10d65))
</details>

<details><summary>barretenberg: 0.27.1</summary>

##
[0.27.1](AztecProtocol/aztec-packages@barretenberg-v0.27.0...barretenberg-v0.27.1)
(2024-03-12)


### Features

* Further ClientIVC breakdown
([#5146](AztecProtocol/aztec-packages#5146))
([c8e1cb8](AztecProtocol/aztec-packages@c8e1cb8))


### Bug Fixes

* Move timers for ClientIVC breakdown
([#5145](AztecProtocol/aztec-packages#5145))
([5457edb](AztecProtocol/aztec-packages@5457edb))


### Miscellaneous

* Share code between provers
([#4655](AztecProtocol/aztec-packages#4655))
([ef10d65](AztecProtocol/aztec-packages@ef10d65))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants