feat(avm): make authwit work with avm #5594

fcarreiro · 2024-04-05T16:07:45Z

No description provided.

fcarreiro · 2024-04-05T16:07:58Z

feat(avm): make authwit work with avm #5594 👈
feat(avm): basic AVM-ACVM interoperability #5595
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

AztecBot · 2024-04-05T16:41:22Z

Benchmark results

Metrics with a significant change:

tx_sequencer_processing_time_ms (5): 1,753 (-17%)
tx_sequencer_processing_time_ms (8): 587 (-18%)
note_successful_decrypting_time_in_ms (8): 295 (+27%)
note_trial_decrypting_time_in_ms (8): 100 (+205%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit f038b704 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,424	6,400	6,424
l1_rollup_execution_gas	585,757	585,733	585,757
l2_block_processing_time_in_ms	1,313	4,756 (+1%)	9,300
note_successful_decrypting_time_in_ms	⚠️ 295 (+27%)	600 (+7%)	1,007 (-6%)
note_trial_decrypting_time_in_ms	⚠️ 100 (+205%)	109 (+50%)	25.2 (-66%)
l2_block_building_time_in_ms	12,003 (+1%)	43,089	84,849 (+1%)
l2_block_rollup_simulation_time_in_ms	11,968 (+1%)	42,961	84,630 (+1%)
l2_block_public_tx_process_time_in_ms	6,284 (+2%)	24,285 (+1%)	48,946 (+2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,663 (-4%)	26,027 (-5%)
note_history_successful_decrypting_time_in_ms	1,302	2,344 (-4%)
note_history_trial_decrypting_time_in_ms	57.1 (-17%)	93.6 (-11%)
node_database_size_in_bytes	18,690,128	34,996,304
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	178 (-1%)	44,377	26,164
private-kernel-ordering	160 (-1%)	50,830	39,026
base-parity	3,868 (-3%)	128	311
root-parity	1,033 (-5%)	1,244	311
base-rollup	14,035 (-1%)	110,464	861
root-rollup	49.3 (-1%)	4,359	725
private-kernel-inner	215	71,744	26,164
public-kernel-app-logic	119	47,695	40,661
public-kernel-tail	163 (-1%)	53,372	7,125
merge-rollup	9.09 (-17%)	2,568	861
public-kernel-teardown	117 (-18%)	47,695	40,661
public-kernel-setup	116 (-1%)	47,695	40,661

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.90 (-2%)	15.8 (-3%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.577 (-2%)	0.490 (-3%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	45.3 (-3%)	71.3 (-2%)	232	431 (-4%)	878 (+1%)	1,728	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.464 (-3%)	0.440 (-2%)	0.423	0.403 (-4%)	0.418 (+1%)	0.413	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	53.4 (-3%)	106 (-1%)	340	636 (-4%)	1,315	2,609	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.471 (-3%)	0.478 (-1%)	0.462 (+1%)	0.438 (-4%)	0.456	0.453	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	59.8 (-3%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.523 (-3%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	40,372	496,534

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,705 (+1%)	1,064 (-1%)	5,409

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	569 (-1%)	398 (-1%)	1,068 (-1%)	493 (-6%)	⚠️ 1,753 (-17%)	⚠️ 587 (-18%)

noir-projects/noir-contracts/contracts/avm_initializer_test_contract/src/main.nr

dbanks12 · 2024-04-08T19:25:44Z

yarn-project/simulator/src/avm/avm_execution_environment.ts

-      this.sender,
+      this.address,


Yikes we had this bug in there? 😬

Yes! 🐛 Now it's solved in the base PR.

dbanks12

LGTM

dbanks12 · 2024-04-09T16:22:13Z

yarn-project/circuits.js/src/contract/artifact_hash.test.ts

@@ -5,7 +5,7 @@ describe('ArtifactHash', () => {
  it('calculates the artifact hash', () => {
    const artifact = getBenchmarkContractArtifact();
    expect(computeArtifactHash(artifact).toString()).toMatchInlineSnapshot(
-      `"0x28d83dfbf4c51a8f79c3f36cfbd8eb36c97b54bb6c42000c0b0bb9b64f600c25"`,
+      `"0x03bc04c08a619ea67445fbecc16863ede06b9314e4e47bba3cefa33354765eb1"`,


Why is this different?

dbanks12 · 2024-04-09T16:23:13Z

yarn-project/end-to-end/src/e2e_avm_simulator.test.ts

+      // This will not work because the ACVM does not see pending nullifiers.
+      // // Cannot work because ACVM does not support pending nullifiers.


Repeated comment?

fcarreiro · 2024-04-09T18:11:12Z

Merge activity

Apr 9, 2:11 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
Apr 9, 2:24 PM EDT: @fcarreiro merged this pull request with Graphite.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.34.0</summary> ## [0.34.0](aztec-package-v0.33.0...aztec-package-v0.34.0) (2024-04-10) ### Miscellaneous * Reduce log verbosity in local e2e tests ([#5622](#5622)) ([c496a10](c496a10)) </details> <details><summary>barretenberg.js: 0.34.0</summary> ## [0.34.0](barretenberg.js-v0.33.0...barretenberg.js-v0.34.0) (2024-04-10) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.34.0</summary> ## [0.34.0](aztec-cli-v0.33.0...aztec-cli-v0.34.0) (2024-04-10) ### Miscellaneous * Reduce log verbosity in local e2e tests ([#5622](#5622)) ([c496a10](c496a10)) </details> <details><summary>aztec-packages: 0.34.0</summary> ## [0.34.0](aztec-packages-v0.33.0...aztec-packages-v0.34.0) (2024-04-10) ### ⚠ BREAKING CHANGES * remove fixed-length keccak256 ([#5617](#5617)) ### Features * **acvm_js:** Execute program (noir-lang/noir#4694) ([ff28080](ff28080)) * Add `remove_enable_side_effects` SSA pass (noir-lang/noir#4224) ([ff28080](ff28080)) * Allow slices to brillig entry points (noir-lang/noir#4713) ([ff28080](ff28080)) * **avm:** Basic AVM-ACVM interoperability ([#5595](#5595)) ([d872445](d872445)) * **avm:** Make authwit work with avm ([#5594](#5594)) ([b02d1e1](b02d1e1)) * **docs:** Documenting noir codegen (noir-lang/noir#4454) ([ff28080](ff28080)) * Generalize protogalaxy to multiple instances ([#5510](#5510)) ([f038b70](f038b70)) * Improve nargo check cli with --override flag and feedback for existing files (noir-lang/noir#4575) ([ff28080](ff28080)) * Improve optimisations on range constraints (noir-lang/noir#4690) ([ff28080](ff28080)) * Improve SSA type-awareness in EQ and MUL instructions (noir-lang/noir#4691) ([ff28080](ff28080)) * **nargo:** Multiple circuits info for binary programs (noir-lang/noir#4719) ([ff28080](ff28080)) * Stdlib databus ([#5598](#5598)) ([633a711](633a711)) ### Bug Fixes * **acvm:** Mark outputs of Opcode::Call solvable (noir-lang/noir#4708) ([ff28080](ff28080)) * Do not retry RPC requests on 4xx errors ([#5634](#5634)) ([5af2b95](5af2b95)) * Field comparisons (noir-lang/noir#4704) ([ff28080](ff28080)) * Last use analysis & make it an SSA pass (noir-lang/noir#4686) ([ff28080](ff28080)) * **ssa:** Do not use get_value_max_num_bits when we want pure type information (noir-lang/noir#4700) ([ff28080](ff28080)) * Unknown slice lengths coming from as_slice (noir-lang/noir#4725) ([ff28080](ff28080)) * Use empty artifact in test ([#5640](#5640)) ([1d18a5e](1d18a5e)) ### Miscellaneous * Check for references to private functions during path resolution (noir-lang/noir#4622) ([ff28080](ff28080)) * **ci:** Fix cutting new versions of the docs (noir-lang/noir#4737) ([ff28080](ff28080)) * **ci:** Replace `yarn build:js:only` script (noir-lang/noir#4735) ([ff28080](ff28080)) * **ci:** Stop updating version list before cutting new docs version (noir-lang/noir#4726) ([ff28080](ff28080)) * Disable earthly cloud ([#5639](#5639)) ([47e9c25](47e9c25)) * Fix clippy errors (noir-lang/noir#4684) ([ff28080](ff28080)) * Reduce log verbosity in local e2e tests ([#5622](#5622)) ([c496a10](c496a10)) * Remove `FunctionInput::dummy` (noir-lang/noir#4723) ([ff28080](ff28080)) * Remove conditional compilation around `acvm_js` package (noir-lang/noir#4702) ([ff28080](ff28080)) * Remove docker CI flow (noir-lang/noir#4724) ([ff28080](ff28080)) * Remove fixed-length keccak256 ([#5617](#5617)) ([40480b3](40480b3)) * Remove last traces of nix (noir-lang/noir#4679) ([ff28080](ff28080)) * Remove unused env vars from `Cross.toml` (noir-lang/noir#4717) ([ff28080](ff28080)) * Replace relative paths to noir-protocol-circuits ([bc214c5](bc214c5)) * Simplify how `acvm_backend.wasm` is embedded (noir-lang/noir#4703) ([ff28080](ff28080)) * Simplify how blns is loaded into tests (noir-lang/noir#4705) ([ff28080](ff28080)) * Update condition for clearing warning comment on release PRs (noir-lang/noir#4739) ([ff28080](ff28080)) * Update from vulnerable version of h2 (noir-lang/noir#4714) ([ff28080](ff28080)) * Update JS publish workflow to upload build artifacts correctly. (noir-lang/noir#4734) ([ff28080](ff28080)) * Use is_entry_point helper on RuntimeType (noir-lang/noir#4678) ([ff28080](ff28080)) </details> <details><summary>barretenberg: 0.34.0</summary> ## [0.34.0](barretenberg-v0.33.0...barretenberg-v0.34.0) (2024-04-10) ### ⚠ BREAKING CHANGES * remove fixed-length keccak256 ([#5617](#5617)) ### Features * Generalize protogalaxy to multiple instances ([#5510](#5510)) ([f038b70](f038b70)) * Stdlib databus ([#5598](#5598)) ([633a711](633a711)) ### Miscellaneous * Remove fixed-length keccak256 ([#5617](#5617)) ([40480b3](40480b3)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.34.0</summary> ## [0.34.0](AztecProtocol/aztec-packages@aztec-package-v0.33.0...aztec-package-v0.34.0) (2024-04-10) ### Miscellaneous * Reduce log verbosity in local e2e tests ([#5622](AztecProtocol/aztec-packages#5622)) ([c496a10](AztecProtocol/aztec-packages@c496a10)) </details> <details><summary>barretenberg.js: 0.34.0</summary> ## [0.34.0](AztecProtocol/aztec-packages@barretenberg.js-v0.33.0...barretenberg.js-v0.34.0) (2024-04-10) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.34.0</summary> ## [0.34.0](AztecProtocol/aztec-packages@aztec-cli-v0.33.0...aztec-cli-v0.34.0) (2024-04-10) ### Miscellaneous * Reduce log verbosity in local e2e tests ([#5622](AztecProtocol/aztec-packages#5622)) ([c496a10](AztecProtocol/aztec-packages@c496a10)) </details> <details><summary>aztec-packages: 0.34.0</summary> ## [0.34.0](AztecProtocol/aztec-packages@aztec-packages-v0.33.0...aztec-packages-v0.34.0) (2024-04-10) ### ⚠ BREAKING CHANGES * remove fixed-length keccak256 ([#5617](AztecProtocol/aztec-packages#5617)) ### Features * **acvm_js:** Execute program (noir-lang/noir#4694) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Add `remove_enable_side_effects` SSA pass (noir-lang/noir#4224) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Allow slices to brillig entry points (noir-lang/noir#4713) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * **avm:** Basic AVM-ACVM interoperability ([#5595](AztecProtocol/aztec-packages#5595)) ([d872445](AztecProtocol/aztec-packages@d872445)) * **avm:** Make authwit work with avm ([#5594](AztecProtocol/aztec-packages#5594)) ([b02d1e1](AztecProtocol/aztec-packages@b02d1e1)) * **docs:** Documenting noir codegen (noir-lang/noir#4454) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Generalize protogalaxy to multiple instances ([#5510](AztecProtocol/aztec-packages#5510)) ([f038b70](AztecProtocol/aztec-packages@f038b70)) * Improve nargo check cli with --override flag and feedback for existing files (noir-lang/noir#4575) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Improve optimisations on range constraints (noir-lang/noir#4690) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Improve SSA type-awareness in EQ and MUL instructions (noir-lang/noir#4691) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * **nargo:** Multiple circuits info for binary programs (noir-lang/noir#4719) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Stdlib databus ([#5598](AztecProtocol/aztec-packages#5598)) ([633a711](AztecProtocol/aztec-packages@633a711)) ### Bug Fixes * **acvm:** Mark outputs of Opcode::Call solvable (noir-lang/noir#4708) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Do not retry RPC requests on 4xx errors ([#5634](AztecProtocol/aztec-packages#5634)) ([5af2b95](AztecProtocol/aztec-packages@5af2b95)) * Field comparisons (noir-lang/noir#4704) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Last use analysis & make it an SSA pass (noir-lang/noir#4686) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * **ssa:** Do not use get_value_max_num_bits when we want pure type information (noir-lang/noir#4700) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Unknown slice lengths coming from as_slice (noir-lang/noir#4725) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Use empty artifact in test ([#5640](AztecProtocol/aztec-packages#5640)) ([1d18a5e](AztecProtocol/aztec-packages@1d18a5e)) ### Miscellaneous * Check for references to private functions during path resolution (noir-lang/noir#4622) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * **ci:** Fix cutting new versions of the docs (noir-lang/noir#4737) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * **ci:** Replace `yarn build:js:only` script (noir-lang/noir#4735) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * **ci:** Stop updating version list before cutting new docs version (noir-lang/noir#4726) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Disable earthly cloud ([#5639](AztecProtocol/aztec-packages#5639)) ([47e9c25](AztecProtocol/aztec-packages@47e9c25)) * Fix clippy errors (noir-lang/noir#4684) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Reduce log verbosity in local e2e tests ([#5622](AztecProtocol/aztec-packages#5622)) ([c496a10](AztecProtocol/aztec-packages@c496a10)) * Remove `FunctionInput::dummy` (noir-lang/noir#4723) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Remove conditional compilation around `acvm_js` package (noir-lang/noir#4702) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Remove docker CI flow (noir-lang/noir#4724) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Remove fixed-length keccak256 ([#5617](AztecProtocol/aztec-packages#5617)) ([40480b3](AztecProtocol/aztec-packages@40480b3)) * Remove last traces of nix (noir-lang/noir#4679) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Remove unused env vars from `Cross.toml` (noir-lang/noir#4717) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Replace relative paths to noir-protocol-circuits ([bc214c5](AztecProtocol/aztec-packages@bc214c5)) * Simplify how `acvm_backend.wasm` is embedded (noir-lang/noir#4703) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Simplify how blns is loaded into tests (noir-lang/noir#4705) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Update condition for clearing warning comment on release PRs (noir-lang/noir#4739) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Update from vulnerable version of h2 (noir-lang/noir#4714) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Update JS publish workflow to upload build artifacts correctly. (noir-lang/noir#4734) ([ff28080](AztecProtocol/aztec-packages@ff28080)) * Use is_entry_point helper on RuntimeType (noir-lang/noir#4678) ([ff28080](AztecProtocol/aztec-packages@ff28080)) </details> <details><summary>barretenberg: 0.34.0</summary> ## [0.34.0](AztecProtocol/aztec-packages@barretenberg-v0.33.0...barretenberg-v0.34.0) (2024-04-10) ### ⚠ BREAKING CHANGES * remove fixed-length keccak256 ([#5617](AztecProtocol/aztec-packages#5617)) ### Features * Generalize protogalaxy to multiple instances ([#5510](AztecProtocol/aztec-packages#5510)) ([f038b70](AztecProtocol/aztec-packages@f038b70)) * Stdlib databus ([#5598](AztecProtocol/aztec-packages#5598)) ([633a711](AztecProtocol/aztec-packages@633a711)) ### Miscellaneous * Remove fixed-length keccak256 ([#5617](AztecProtocol/aztec-packages#5617)) ([40480b3](AztecProtocol/aztec-packages@40480b3)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

fcarreiro mentioned this pull request Apr 5, 2024

feat(avm): add Header to AvmExecutionEnvironment #5592

Closed

fcarreiro mentioned this pull request Apr 5, 2024

feat(avm): basic AVM-ACVM interoperability #5593

Closed

fcarreiro force-pushed the fc/avm-simulator-interoperability branch from 0d29922 to 68b544b Compare April 5, 2024 16:08

fcarreiro force-pushed the fc/avm-authwit-integration branch from 425f059 to c4224b2 Compare April 5, 2024 16:08

fcarreiro force-pushed the fc/avm-authwit-integration branch from c4224b2 to 08435ca Compare April 5, 2024 17:23

fcarreiro changed the base branch from fc/avm-simulator-interoperability to fc/avm-simulator-interoperability-2 April 5, 2024 17:23

fcarreiro mentioned this pull request Apr 5, 2024

feat(avm): basic AVM-ACVM interoperability #5595

Merged

fcarreiro force-pushed the fc/avm-simulator-interoperability-2 branch from 1ca2df4 to 4de7056 Compare April 8, 2024 15:33

fcarreiro force-pushed the fc/avm-authwit-integration branch from 08435ca to d82991c Compare April 8, 2024 15:33

fcarreiro force-pushed the fc/avm-simulator-interoperability-2 branch from 4de7056 to 1563987 Compare April 8, 2024 16:02

fcarreiro force-pushed the fc/avm-authwit-integration branch from d82991c to 90ad1cb Compare April 8, 2024 16:02

fcarreiro force-pushed the fc/avm-simulator-interoperability-2 branch from 1563987 to 2e89a28 Compare April 8, 2024 16:55

fcarreiro force-pushed the fc/avm-authwit-integration branch from 90ad1cb to 7038713 Compare April 8, 2024 16:55

fcarreiro force-pushed the fc/avm-simulator-interoperability-2 branch from 2e89a28 to 6ccd909 Compare April 8, 2024 18:10

dbanks12 reviewed Apr 8, 2024

View reviewed changes

fcarreiro force-pushed the fc/avm-simulator-interoperability-2 branch from 6ccd909 to dd50e6f Compare April 9, 2024 09:23

fcarreiro force-pushed the fc/avm-authwit-integration branch from 7038713 to 6d44bda Compare April 9, 2024 09:23

fcarreiro force-pushed the fc/avm-simulator-interoperability-2 branch from dd50e6f to 258ed4e Compare April 9, 2024 09:29

fcarreiro force-pushed the fc/avm-authwit-integration branch from 6d44bda to 1510ce8 Compare April 9, 2024 09:29

fcarreiro force-pushed the fc/avm-simulator-interoperability-2 branch from 258ed4e to c1816b0 Compare April 9, 2024 10:07

fcarreiro force-pushed the fc/avm-authwit-integration branch from 1510ce8 to 6b5ba6e Compare April 9, 2024 10:07

fcarreiro force-pushed the fc/avm-simulator-interoperability-2 branch from c1816b0 to fb1def3 Compare April 9, 2024 10:31

fcarreiro force-pushed the fc/avm-authwit-integration branch from 6b5ba6e to 0e28e71 Compare April 9, 2024 10:31

fcarreiro force-pushed the fc/avm-simulator-interoperability-2 branch from fb1def3 to 8416597 Compare April 9, 2024 11:02

fcarreiro force-pushed the fc/avm-authwit-integration branch 2 times, most recently from b9b7236 to ab42020 Compare April 9, 2024 11:31

fcarreiro marked this pull request as ready for review April 9, 2024 11:41

dbanks12 approved these changes Apr 9, 2024

View reviewed changes

fcarreiro force-pushed the fc/avm-simulator-interoperability-2 branch from 8416597 to e733a83 Compare April 9, 2024 17:29

fcarreiro requested a review from Maddiaa0 as a code owner April 9, 2024 17:29

fcarreiro force-pushed the fc/avm-authwit-integration branch from ab42020 to fe87de6 Compare April 9, 2024 17:29

fcarreiro force-pushed the fc/avm-simulator-interoperability-2 branch from e733a83 to 8fc5b98 Compare April 9, 2024 17:32

fcarreiro force-pushed the fc/avm-authwit-integration branch from fe87de6 to f31c8c5 Compare April 9, 2024 17:32

Base automatically changed from fc/avm-simulator-interoperability-2 to master April 9, 2024 18:09

feat(avm): make authwit work with avm

aefff44

fcarreiro force-pushed the fc/avm-authwit-integration branch from f31c8c5 to aefff44 Compare April 9, 2024 18:10

fcarreiro merged commit b02d1e1 into master Apr 9, 2024
103 of 104 checks passed

fcarreiro deleted the fc/avm-authwit-integration branch April 9, 2024 18:24

AztecBot mentioned this pull request Apr 9, 2024

chore(master): Release 0.34.0 #5629

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(avm): make authwit work with avm #5594

feat(avm): make authwit work with avm #5594

fcarreiro commented Apr 5, 2024 •

edited

Loading

fcarreiro commented Apr 5, 2024 •

edited

Loading

AztecBot commented Apr 5, 2024 •

edited

Loading

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

dbanks12 Apr 8, 2024

fcarreiro Apr 9, 2024

dbanks12 left a comment

dbanks12 Apr 9, 2024

dbanks12 Apr 9, 2024

fcarreiro commented Apr 9, 2024 •

edited

Loading

		// This will not work because the ACVM does not see pending nullifiers.
		// // Cannot work because ACVM does not support pending nullifiers.

feat(avm): make authwit work with avm #5594

feat(avm): make authwit work with avm #5594

Conversation

fcarreiro commented Apr 5, 2024 • edited Loading

fcarreiro commented Apr 5, 2024 • edited Loading

AztecBot commented Apr 5, 2024 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

dbanks12 Apr 8, 2024

Choose a reason for hiding this comment

fcarreiro Apr 9, 2024

Choose a reason for hiding this comment

dbanks12 left a comment

Choose a reason for hiding this comment

dbanks12 Apr 9, 2024

Choose a reason for hiding this comment

dbanks12 Apr 9, 2024

Choose a reason for hiding this comment

fcarreiro commented Apr 9, 2024 • edited Loading

Merge activity

fcarreiro commented Apr 5, 2024 •

edited

Loading

fcarreiro commented Apr 5, 2024 •

edited

Loading

AztecBot commented Apr 5, 2024 •

edited

Loading

fcarreiro commented Apr 9, 2024 •

edited

Loading