feat: avm support for public input columns

[Maddiaa0]

Adds support for public input columns as outlined in the following hackmd: https://hackmd.io/8kkJo4RkRTG6mpwL8fOf3w?both

There are some temporary deviations from the spec that have been made to avoid changing the sumcheck / zeromorph code.

In this implementation we let the prover commit to the public input columns, this means that during sumcheck the public input columns are evaluated at the same challenge points as the other commitments. Therefore the claimed_evaluation for the public inputs can be accumulated in zeromorph in the same way all of the other polynomials are.

[[for me: how to do what is described in the hackmd]]
To do exactly what is described in the hackmd, we would be required to hash each of the public inputs, then perform the same opening.
We can then remove the prover committing to the public input columns, and remove the opening of the public input columns from zeromorph.
[[/for me]]

For the meantime, pil and the prover will support a single public inputs column, but in the future we can extend the scheme where we evaluate the poly in the verifier for any number of columns.

[Maddiaa0]

• feat(vm): reading kernel state opcodes #5739
• feat: avm support for public input columns #5700 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Maddiaa0 and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	772	772	772
l1_rollup_calldata_gas	6,832	6,844	6,820
l1_rollup_execution_gas	587,313	587,325	587,301
l2_block_processing_time_in_ms	1,548 (+5%)	5,314 (-1%)	10,347
note_successful_decrypting_time_in_ms	221 (-11%)	569 (+2%)	1,008 (+6%)
note_trial_decrypting_time_in_ms	20.4 (-58%)	74.3 (+13%)	27.0 (-61%)
l2_block_building_time_in_ms	18,196	70,650 (-1%)	141,826 (-1%)
l2_block_rollup_simulation_time_in_ms	17,956	69,802 (-1%)	140,158 (-1%)
l2_block_public_tx_process_time_in_ms	8,258	31,783 (-1%)	63,880 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	16,016 (-3%)	30,743 (+2%)
note_history_successful_decrypting_time_in_ms	1,220 (-3%)	2,362 (-6%)
note_history_trial_decrypting_time_in_ms	117 (+72%)	86.4 (-26%)
node_database_size_in_bytes	19,148,880	35,844,176
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	149 (-2%)	45,173	27,384
private-kernel-inner	164 (-1%)	73,608	27,384
private-kernel-ordering	119 (-2%)	53,138	41,123
base-parity	45.6	128	311
root-parity	7.32 (-2%)	1,244	311
base-rollup	19,059 (-1%)	110,928	957
root-rollup	47.4 (-1%)	4,551	821
public-kernel-app-logic	91.8 (-2%)	50,319	42,853
public-kernel-tail	375 (-2%)	159,352	7,493
merge-rollup	7.46 (+5%)	2,760	957
public-kernel-teardown	87.6	50,319	42,853
public-kernel-setup	86.4	50,319	42,853

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.1 (-1%)	17.7 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.643 (-1%)	0.546 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	52.1 (-1%)	80.5 (-1%)	264 (+2%)	506 (-2%)	979 (-2%)	1,918 (-2%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.534 (-1%)	0.496	0.481 (+2%)	0.472 (-2%)	0.465 (-2%)	0.459 (-2%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.9 (-1%)	119 (-2%)	378	749 (-2%)	1,454 (-2%)	2,876 (-2%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.538 (-1%)	0.534 (-1%)	0.510	0.513 (-2%)	0.503 (-2%)	0.500 (-2%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	67.4 (-1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.588 (-1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	42,886	535,757

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	897	1,145	1,345

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,263 (+1%)	837 (-3%)	3,473

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	794 (-3%)	670	1,292 (+1%)	874	1,972 (+1%)	1,132 (+1%)

[jeanmon]

Good job! Look at my feedback before merging.

[jeanmon]

Probably it does not hurt, but I thought that the prover would not generate the commitment for public columns.

[Maddiaa0]

You are correct, the pr description goes over the current approach, as a temporary step this is enough. Otherwise we would need to hash each public input individually.

[jeanmon]

@Maddiaa0 Ok. Could you just make sure we keep a ticket or a reminder somewhere about this?

[jeanmon]

Is this missing?

[Maddiaa0]

Ah, ill make codegen remove this comment, there were no lookups in this so there are no inverse commitments required