Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: nuking GrumpkinScalar #6240

Merged
merged 1 commit into from
May 7, 2024

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented May 7, 2024

All the aztec usecases were already replaced with a GrumpkinPrivateKey which is basically a duplicate of GrumpkinScalar.

Fixes noir-lang/noir#4968

Copy link
Contributor Author

benesjan commented May 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite Graphite

@benesjan benesjan changed the title refactor: nuking GrumpkinScalar refactor: nuking GrumpkinScalar May 7, 2024
Base automatically changed from 04-30-feat_multi_scalar_mul_blackbox_func to master May 7, 2024 14:20
@benesjan benesjan force-pushed the 05-07-refactor_nuking_grumpkinscalar branch from c096531 to 59ba00b Compare May 7, 2024 14:33
@benesjan benesjan marked this pull request as ready for review May 7, 2024 14:59
@TomAFrench TomAFrench enabled auto-merge (squash) May 7, 2024 15:21
@TomAFrench TomAFrench merged commit d2df10d into master May 7, 2024
67 of 90 checks passed
@TomAFrench TomAFrench deleted the 05-07-refactor_nuking_grumpkinscalar branch May 7, 2024 15:26
TomAFrench added a commit to noir-lang/noir that referenced this pull request May 8, 2024
Automated pull of Noir development from
[aztec-packages](https://github.com/AztecProtocol/aztec-packages).
BEGIN_COMMIT_OVERRIDE
feat!: AES blackbox
(AztecProtocol/aztec-packages#6016)
chore(aztec-macros): avm function return types are auto tagged as `pub`
(AztecProtocol/aztec-packages#6250)
refactor: nuking `GrumpkinScalar`
(AztecProtocol/aztec-packages#6240)
feat: `multi_scalar_mul` blackbox func
(AztecProtocol/aztec-packages#6097)
feat: Set aztec private functions to be recursive
(AztecProtocol/aztec-packages#6192)
feat: Parsing non-string assertion payloads in noir js
(AztecProtocol/aztec-packages#6079)
feat: `variable_base_scalar_mul` blackbox func
(AztecProtocol/aztec-packages#6039)
feat: Dynamic assertion payloads v2
(AztecProtocol/aztec-packages#5949)
chore!: remove `Opcode::Brillig` from ACIR
(AztecProtocol/aztec-packages#5995)
END_COMMIT_OVERRIDE

---------

Co-authored-by: Tom French <tom@tomfren.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move GrumpkinScalar out of std
2 participants