Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: remove nargo prove and nargo verify #6321

Merged
merged 6 commits into from
May 16, 2024
Merged

chore!: remove nargo prove and nargo verify #6321

merged 6 commits into from
May 16, 2024

Conversation

TomAFrench
Copy link
Member

No description provided.

@Savio-Sou Savio-Sou mentioned this pull request May 10, 2024
Closed
@TomAFrench TomAFrench force-pushed the tf/remove-codegen-verifier branch 2 times, most recently from 6a9a04c to 96b58f7 Compare May 10, 2024 17:00
@Savio-Sou
Copy link
Member

If without bb workspace support, would this change regresses to require users running multiple commands / defining custom shell scripts to prove and verify multiple Noir programs within a workspace?

@TomAFrench
Copy link
Member Author

Yes, and that's ok.

@TomAFrench TomAFrench force-pushed the tf/remove-prove-verify branch 2 times, most recently from 3f8f614 to a77c447 Compare May 16, 2024 13:18
@TomAFrench TomAFrench requested a review from vezenovm May 16, 2024 14:26
vezenovm
vezenovm approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@vezenovm vezenovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should plan to get some initial barretenberg cli docs in with all these nargo rescoping PRs

@Savio-Sou
Copy link
Member

approved

(Should we block this PR to avoid accidental merges before noir-lang/noir#4960 is fully addressed? Would be great to land all corresponding PRs under the same Noir version.)

@TomAFrench
Copy link
Member Author

We can handle merging these properly.

We'd need to sync these changes to the other repository for them to make it into a release anyway.

@TomAFrench TomAFrench marked this pull request as ready for review May 16, 2024 19:48
@TomAFrench TomAFrench merged commit eadaa0d into tf/remove-codegen-verifier May 16, 2024
93 of 94 checks passed
@TomAFrench TomAFrench deleted the tf/remove-prove-verify branch May 16, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vezenovm vezenovm vezenovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TomAFrench @Savio-Sou @vezenovm