Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: bump maximum nullifier read requests (necessary for e2e tests in AVM)" #6483

Merged
merged 1 commit into from
May 16, 2024

Conversation

dbanks12
Copy link
Contributor

Reverts #6462

@ludamad ludamad merged commit 30ca824 into master May 16, 2024
31 of 34 checks passed
@ludamad ludamad deleted the revert-6462-db/bump-max-nullifier-rrs branch May 16, 2024 19:31
@AztecBot
Copy link
Collaborator

Benchmark results

Metrics with a significant change:

  • protocol_circuit_simulation_time_in_ms (private-kernel-inner): 417 (-23%)
  • protocol_circuit_simulation_time_in_ms (private-kernel-reset): 678 (-32%)
  • protocol_circuit_simulation_time_in_ms (private-kernel-tail): 444 (-17%)
  • protocol_circuit_simulation_time_in_ms (public-kernel-tail): 536 (-40%)
  • protocol_circuit_input_size_in_bytes (private-kernel-inner): 72,583 (-19%)
  • protocol_circuit_input_size_in_bytes (private-kernel-reset): 219,992 (-34%)
  • protocol_circuit_input_size_in_bytes (private-kernel-tail): 70,968 (-19%)
  • protocol_circuit_input_size_in_bytes (public-kernel-app-logic): 78,387 (-19%)
  • protocol_circuit_input_size_in_bytes (public-kernel-tail): 184,419 (-52%)
  • protocol_circuit_input_size_in_bytes (public-kernel-setup): 110,522 (-19%)
  • protocol_circuit_input_size_in_bytes (public-kernel-teardown): 114,417 (-19%)
  • protocol_circuit_output_size_in_bytes (private-kernel-init): 46,118 (-26%)
  • protocol_circuit_output_size_in_bytes (private-kernel-inner): 46,118 (-26%)
  • protocol_circuit_output_size_in_bytes (private-kernel-reset): 46,118 (-26%)
  • protocol_circuit_output_size_in_bytes (private-kernel-tail): 64,320 (-19%)
  • protocol_circuit_output_size_in_bytes (public-kernel-app-logic): 68,775 (-19%)
  • protocol_circuit_output_size_in_bytes (public-kernel-setup): 68,775 (-19%)
  • protocol_circuit_output_size_in_bytes (public-kernel-teardown): 68,775 (-19%)
  • tx_pxe_processing_time_ms (0): 27,978 (-25%)
  • tx_pxe_processing_time_ms (1): 3,078 (-16%)
  • tx_pxe_processing_time_ms (2): 91,675 (-18%)
  • tx_size_in_bytes (0): 68,448 (-19%)
  • tx_sequencer_processing_time_ms (0): 840 (-45%)
  • tx_sequencer_processing_time_ms (1): 1,562 (-31%)
  • tx_sequencer_processing_time_ms (2): 1,328 (-30%)
  • tx_sequencer_processing_time_ms (4): 2,177 (-24%)
  • tx_sequencer_processing_time_ms (8): 1,331 (-27%)
  • app_circuit_proving_time_in_ms (FPC:fee_entrypoint_public): 13,484 (+54%)
  • app_circuit_proving_time_in_ms (FPC:fee_entrypoint_private): 11,217 (-36%)
  • app_circuit_proving_time_in_ms (Token:unshield): 33,779 (-27%)
  • protocol_circuit_witness_generation_time_in_ms (private-kernel-init): 2,593 (-28%)
  • protocol_circuit_witness_generation_time_in_ms (private-kernel-inner): 3,638 (-19%)
  • protocol_circuit_witness_generation_time_in_ms (private-kernel-reset): 4,364 (-31%)
  • protocol_circuit_witness_generation_time_in_ms (base-parity): 205 (-62%)
  • protocol_circuit_witness_generation_time_in_ms (public-kernel-app-logic): 255 (-28%)
  • protocol_circuit_witness_generation_time_in_ms (public-kernel-tail): 619 (-36%)
  • protocol_circuit_proving_time_in_ms (private-kernel-reset): 45,549 (-48%)
  • protocol_circuit_proving_time_in_ms (private-kernel-tail-to-public): 43,286 (-37%)
  • protocol_circuit_proving_time_in_ms (base-parity): 3,291 (-17%)
  • protocol_circuit_proving_time_in_ms (public-kernel-tail): 769 (-28%)
  • protocol_circuit_proving_time_in_ms (merge-rollup): 2,123 (+33%)
  • protocol_circuit_proof_size_in_bytes (private-kernel-init): 62,400 (-27%)
  • protocol_circuit_proof_size_in_bytes (private-kernel-inner): 62,400 (-27%)
  • protocol_circuit_proof_size_in_bytes (private-kernel-reset): 62,400 (-27%)
  • protocol_circuit_proof_size_in_bytes (private-kernel-tail-to-public): 90,944 (-20%)
  • protocol_circuit_proof_size_in_bytes (public-kernel-setup): 90,432 (-20%)
  • protocol_circuit_proof_size_in_bytes (public-kernel-app-logic): 90,432 (-20%)
  • protocol_circuit_proof_size_in_bytes (public-kernel-teardown): 90,432 (-20%)
  • protocol_circuit_size_in_gates (private-kernel-reset): 2,097,152 (-50%)
  • protocol_circuit_size_in_gates (private-kernel-tail-to-public): 2,097,152 (-50%)
  • protocol_circuit_num_public_inputs (private-kernel-init): 1,883 (-28%)
  • protocol_circuit_num_public_inputs (private-kernel-inner): 1,883 (-28%)
  • protocol_circuit_num_public_inputs (private-kernel-reset): 1,883 (-28%)
  • protocol_circuit_num_public_inputs (private-kernel-tail-to-public): 2,775 (-21%)
  • protocol_circuit_num_public_inputs (public-kernel-setup): 2,759 (-21%)
  • protocol_circuit_num_public_inputs (public-kernel-app-logic): 2,759 (-21%)
  • protocol_circuit_num_public_inputs (public-kernel-teardown): 2,759 (-21%)
  • l2_block_building_time_in_ms (8): 26,907 (-24%)
  • l2_block_building_time_in_ms (32): 105,246 (-24%)
  • l2_block_building_time_in_ms (64): 209,607 (-24%)
  • l2_block_rollup_simulation_time_in_ms (8): 26,724 (-24%)
  • l2_block_rollup_simulation_time_in_ms (32): 104,597 (-24%)
  • l2_block_rollup_simulation_time_in_ms (64): 208,353 (-24%)
  • l2_block_public_tx_process_time_in_ms (8): 11,967 (-27%)
  • l2_block_public_tx_process_time_in_ms (32): 50,884 (-27%)
  • l2_block_public_tx_process_time_in_ms (64): 102,517 (-28%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 740 740 740
l1_rollup_calldata_gas 6,692 6,692 6,692
l1_rollup_execution_gas 586,877 586,877 586,877
l2_block_processing_time_in_ms 1,618 6,078 12,048
l2_block_building_time_in_ms ⚠️ 26,907 (-24%) ⚠️ 105,246 (-24%) ⚠️ 209,607 (-24%)
l2_block_rollup_simulation_time_in_ms ⚠️ 26,724 (-24%) ⚠️ 104,597 (-24%) ⚠️ 208,353 (-24%)
l2_block_public_tx_process_time_in_ms ⚠️ 11,967 (-27%) ⚠️ 50,884 (-27%) ⚠️ 102,517 (-28%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 18,066 33,435 (-1%)
node_database_size_in_bytes 21,323,856 38,002,768
pxe_database_size_in_bytes 29,868 59,425

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit protocol_circuit_simulation_time_in_ms protocol_circuit_witness_generation_time_in_ms protocol_circuit_proving_time_in_ms protocol_circuit_input_size_in_bytes protocol_circuit_output_size_in_bytes protocol_circuit_proof_size_in_bytes protocol_circuit_num_public_inputs protocol_circuit_size_in_gates
private-kernel-init 141 (-13%) ⚠️ 2,593 (-28%) 21,883 (+3%) 19,396 (-5%) ⚠️ 46,118 (-26%) ⚠️ 62,400 (-27%) ⚠️ 1,883 (-28%) 1,048,576
private-kernel-inner ⚠️ 417 (-23%) ⚠️ 3,638 (-19%) 38,149 (-12%) ⚠️ 72,583 (-19%) ⚠️ 46,118 (-26%) ⚠️ 62,400 (-27%) ⚠️ 1,883 (-28%) 2,097,152
private-kernel-reset ⚠️ 678 (-32%) ⚠️ 4,364 (-31%) ⚠️ 45,549 (-48%) ⚠️ 219,992 (-34%) ⚠️ 46,118 (-26%) ⚠️ 62,400 (-27%) ⚠️ 1,883 (-28%) ⚠️ 2,097,152 (-50%)
private-kernel-tail ⚠️ 444 (-17%) 4,605 (-2%) 36,935 (-2%) ⚠️ 70,968 (-19%) ⚠️ 64,320 (-19%) 10,656 266 2,097,152
base-parity 8.17 (-1%) ⚠️ 205 (-62%) ⚠️ 3,291 (-17%) 128 64.0 2,208 2.00 131,072
root-parity 51.5 154 (+16%) 38,189 (-2%) 27,064 64.0 2,720 18.0 2,097,152
base-rollup 825 (-11%) 4,820 (+1%) 43,175 111,126 925 3,104 30.0 2,097,152
root-rollup 72.5 179 (+4%) 8,214 11,454 789 3,424 40.0 524,288
public-kernel-app-logic 155 (-20%) ⚠️ 255 (-28%) 985 (+1%) ⚠️ 78,387 (-19%) ⚠️ 68,775 (-19%) ⚠️ 90,432 (-20%) ⚠️ 2,759 (-21%) 4,096
public-kernel-tail ⚠️ 536 (-40%) ⚠️ 619 (-36%) ⚠️ 769 (-28%) ⚠️ 184,419 (-52%) 7,723 10,144 250 512
public-kernel-setup 132 (-19%) 356 (-12%) 850 (-6%) ⚠️ 110,522 (-19%) ⚠️ 68,775 (-19%) ⚠️ 90,432 (-20%) ⚠️ 2,759 (-21%) 4,096
public-kernel-teardown 140 (-18%) 427 (-7%) 1,024 (-4%) ⚠️ 114,417 (-19%) ⚠️ 68,775 (-19%) ⚠️ 90,432 (-20%) ⚠️ 2,759 (-21%) 4,096
merge-rollup 6.82 (-1%) 107 (+26%) ⚠️ 2,123 (+33%) 2,696 925 3,104 30.0 65,536
private-kernel-tail-to-public N/A 8,908 (-7%) ⚠️ 43,286 (-37%) N/A N/A ⚠️ 90,944 (-20%) ⚠️ 2,775 (-21%) ⚠️ 2,097,152 (-50%)

Stats on running time collected for app circuits

Function app_circuit_proof_size_in_bytes app_circuit_proving_time_in_ms app_circuit_size_in_gates app_circuit_num_public_inputs
SchnorrAccount:entrypoint 13,600 (-12%) 46,163 (-5%) 2,097,152 358 (-14%)
Test:emit_nullifier 13,600 (-12%) 2,328 (+2%) 65,536 358 (-14%)
FPC:fee_entrypoint_public 13,600 (-12%) ⚠️ 13,484 (+54%) 524,288 358 (-14%)
Token:transfer 13,600 (-12%) 44,009 (+11%) 2,097,152 358 (-14%)
FPC:fee_entrypoint_private 13,600 (-12%) ⚠️ 11,217 (-36%) 524,288 358 (-14%)
Token:unshield 13,600 (-12%) ⚠️ 33,779 (-27%) 2,097,152 358 (-14%)
SchnorrAccount:spend_private_authwit 13,600 (-12%) 2,574 (-4%) 131,072 358 (-14%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 13.1 21.3 (-1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.7 31.8 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.767 0.658 (-1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 62.0 97.0 (-2%) 317 611 1,190 2,363 N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.636 0.600 (-2%) 0.576 0.572 0.563 (-1%) 0.565 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 73.9 144 (+1%) 456 891 1,775 3,543 N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 106 208 692 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.645 0.648 (+1%) 0.619 0.615 0.615 0.616 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 80.6
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 108
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.709

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes ⚠️ 68,448 (-19%) 668,029 (-1%)

Transaction size based on fee payment method

| Metric | |
| - | |

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms ⚠️ 27,978 (-25%) ⚠️ 3,078 (-16%) ⚠️ 91,675 (-18%)
Metric 0 public data writes 1 public data writes 2 public data writes 4 public data writes 8 public data writes
tx_sequencer_processing_time_ms ⚠️ 840 (-45%) ⚠️ 1,562 (-31%) ⚠️ 1,328 (-30%) ⚠️ 2,177 (-24%) ⚠️ 1,331 (-27%)

github-merge-queue bot pushed a commit to noir-lang/noir that referenced this pull request May 22, 2024
Automated pull of Noir development from
[aztec-packages](https://github.com/AztecProtocol/aztec-packages).
BEGIN_COMMIT_OVERRIDE
feat: Sync from noir
(AztecProtocol/aztec-packages#6573)
feat!: compile-time incorrect exec environment errors
(AztecProtocol/aztec-packages#6442)
feat: Sync from noir
(AztecProtocol/aztec-packages#6555)
feat: View functions with static context enforcing
(AztecProtocol/aztec-packages#6338)
feat!: add is_infinite to curve addition opcode
(AztecProtocol/aztec-packages#6384)
feat: Sync from noir
(AztecProtocol/aztec-packages#6500)
chore!: remove backend interactions from `nargo`
(AztecProtocol/aztec-packages#6320)
fix: removed plain from path in array args of contract interfaces
(AztecProtocol/aztec-packages#6497)
chore: bump maximum nullifier read requests (necessary for e2e tests in
AVM) (AztecProtocol/aztec-packages#6495)
Revert "chore: bump maximum nullifier read requests (necessary for e2e
tests in AVM)"
(AztecProtocol/aztec-packages#6483)
chore: bump maximum nullifier read requests (necessary for e2e tests in
AVM) (AztecProtocol/aztec-packages#6462)
fix: Check for public args in aztec functions
(AztecProtocol/aztec-packages#6355)
feat: Move abi demonomorphizer to noir_codegen and use noir_codegen in
protocol types
(AztecProtocol/aztec-packages#6302)
feat!: switch `bb` over to read ACIR from nargo artifacts
(AztecProtocol/aztec-packages#6283)
feat: ToRadix BB + avm transpiler support
(AztecProtocol/aztec-packages#6330)
feat: Sync from noir
(AztecProtocol/aztec-packages#6332)
fix: temporarily revert to_radix blackbox
(AztecProtocol/aztec-packages#6304)
feat: move to_radix to a blackbox
(AztecProtocol/aztec-packages#6294)
chore: skip formatting informattable comments
(AztecProtocol/aztec-packages#6288)
chore(dsl): Update backend gateCount command to query a Program in a
single request
(AztecProtocol/aztec-packages#6228)
feat: Private Kernel Recursion
(AztecProtocol/aztec-packages#6278)
feat: Proper padding in ts AES and constrained AES in body and header
computations (AztecProtocol/aztec-packages#6269)
chore: simplify nargo CLI to read from artifacts
(AztecProtocol/aztec-packages#6279)
feat: Sync from noir
(AztecProtocol/aztec-packages#6280)
chore: enforce formatting of noir code
(AztecProtocol/aztec-packages#6271)
feat!: specify databus arrays for BB
(AztecProtocol/aztec-packages#6239)
END_COMMIT_OVERRIDE

---------

Co-authored-by: TomAFrench <tom@tomfren.ch>
github-merge-queue bot pushed a commit to noir-lang/noir that referenced this pull request May 22, 2024
Automated pull of Noir development from
[aztec-packages](https://github.com/AztecProtocol/aztec-packages).
BEGIN_COMMIT_OVERRIDE
feat: Sync from noir
(AztecProtocol/aztec-packages#6573)
feat!: compile-time incorrect exec environment errors
(AztecProtocol/aztec-packages#6442)
feat: Sync from noir
(AztecProtocol/aztec-packages#6555)
feat: View functions with static context enforcing
(AztecProtocol/aztec-packages#6338)
feat!: add is_infinite to curve addition opcode
(AztecProtocol/aztec-packages#6384)
feat: Sync from noir
(AztecProtocol/aztec-packages#6500)
chore!: remove backend interactions from `nargo`
(AztecProtocol/aztec-packages#6320)
fix: removed plain from path in array args of contract interfaces
(AztecProtocol/aztec-packages#6497)
chore: bump maximum nullifier read requests (necessary for e2e tests in
AVM) (AztecProtocol/aztec-packages#6495)
Revert "chore: bump maximum nullifier read requests (necessary for e2e
tests in AVM)"
(AztecProtocol/aztec-packages#6483)
chore: bump maximum nullifier read requests (necessary for e2e tests in
AVM) (AztecProtocol/aztec-packages#6462)
fix: Check for public args in aztec functions
(AztecProtocol/aztec-packages#6355)
feat: Move abi demonomorphizer to noir_codegen and use noir_codegen in
protocol types
(AztecProtocol/aztec-packages#6302)
feat!: switch `bb` over to read ACIR from nargo artifacts
(AztecProtocol/aztec-packages#6283)
feat: ToRadix BB + avm transpiler support
(AztecProtocol/aztec-packages#6330)
feat: Sync from noir
(AztecProtocol/aztec-packages#6332)
fix: temporarily revert to_radix blackbox
(AztecProtocol/aztec-packages#6304)
feat: move to_radix to a blackbox
(AztecProtocol/aztec-packages#6294)
chore: skip formatting informattable comments
(AztecProtocol/aztec-packages#6288)
chore(dsl): Update backend gateCount command to query a Program in a
single request
(AztecProtocol/aztec-packages#6228)
feat: Private Kernel Recursion
(AztecProtocol/aztec-packages#6278)
feat: Proper padding in ts AES and constrained AES in body and header
computations (AztecProtocol/aztec-packages#6269)
chore: simplify nargo CLI to read from artifacts
(AztecProtocol/aztec-packages#6279)
feat: Sync from noir
(AztecProtocol/aztec-packages#6280)
chore: enforce formatting of noir code
(AztecProtocol/aztec-packages#6271)
feat!: specify databus arrays for BB
(AztecProtocol/aztec-packages#6239)
END_COMMIT_OVERRIDE

---------

Co-authored-by: TomAFrench <tom@tomfren.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants