Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from noir #6801

Merged
merged 13 commits into from
Jun 6, 2024
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ describe('e2e_fees private_payment', () => {
* TODO(6583): update this comment properly now that public execution consumes gas
*/

expect(tx.transactionFee).toEqual(200036352n);
expect(tx.transactionFee).toEqual(200032492n);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these exact fee asserts a good idea?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

await expect(t.getCoinbaseBalance()).resolves.toEqual(InitialSequencerL1Gas + tx.transactionFee!);
const [feeAmount, refundAmount] = getFeeAndRefund(tx);

Expand Down