Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AllValues and std::array<FF, N> asymmetry in prover/verifier #846

Closed
lucasxia01 opened this issue Feb 5, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#4537
Closed

AllValues and std::array<FF, N> asymmetry in prover/verifier #846

lucasxia01 opened this issue Feb 5, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#4537

Comments

@lucasxia01
Copy link
Contributor

When we receive_from_prover for the sumcheck evaluations, the type we expect is std::array<FF, NUM_POLYNOMIALS>.
On the other side, when we send_to_verifier, we send an AllValues object. This asymmetry results in asymmetric conversion functions.

The underlying data is the same so there's no bug, but we should probably clean this up in case.
@lucasxia01 lucasxia01 mentioned this issue Feb 9, 2024
Merged
lucasxia01 added a commit to AztecProtocol/aztec-packages that referenced this issue Feb 12, 2024
@lucasxia01
refactor: updating field conversion code without pointer hack (#4537)
94f436e 
We currently use a pointer hack for functions like `calc_num_bn254_frs`
and `convert_from_bn254_frs`. This PR aims to clean these up using
traits and template metaprogramming.

Also closes AztecProtocol/barretenberg#846, by
just sending and receiving an std::array instead of an AllValues object.
AztecBot pushed a commit that referenced this issue Feb 13, 2024
@lucasxia01 @AztecBot
refactor: updating field conversion code without pointer hack (#4537)
4e529dd 
We currently use a pointer hack for functions like `calc_num_bn254_frs`
and `convert_from_bn254_frs`. This PR aims to clean these up using
traits and template metaprogramming.

Also closes #846, by
just sending and receiving an std::array instead of an AllValues object.
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@lucasxia01
refactor: updating field conversion code without pointer hack (AztecP…
949c9cb 
…rotocol#4537)

We currently use a pointer hack for functions like `calc_num_bn254_frs`
and `convert_from_bn254_frs`. This PR aims to clean these up using
traits and template metaprogramming.

Also closes AztecProtocol/barretenberg#846, by
just sending and receiving an std::array instead of an AllValues object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: updating field conversion code without pointer hack AztecProtocol/aztec-packages
1 participant
@lucasxia01