Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verify_proof in Noir Docs #148

Closed
2 tasks
signorecello opened this issue Jan 25, 2024 · 1 comment · Fixed by noir-lang/noir#4187
Closed
2 tasks

Fix verify_proof in Noir Docs #148

signorecello opened this issue Jan 25, 2024 · 1 comment · Fixed by noir-lang/noir#4187
Assignees
@signorecello
Labels
Noir Docs

Comments

@signorecello
Copy link
Collaborator

signorecello commented Jan 25, 2024 •
edited
Loading

Related with this issue

Needs to move to top prio

Tasks
Beta Give feedback
@signorecello signorecello self-assigned this Jan 25, 2024
@signorecello
Copy link
Collaborator Author

signorecello commented Jan 25, 2024 •
edited
Loading

Ok this is bigger than I thought because of noir_examples and the tutorials, gonna assign "small"

@signorecello signorecello mentioned this issue Jan 27, 2024
Merged
github-merge-queue bot pushed a commit to noir-lang/noir that referenced this issue Jan 30, 2024
@signorecello @catmcgee
chore(docs): updating docs to match new recursion interfacee (#4187)
f4de6ee 
# Description

This PR documents the new recursion interface.

## Problem\*

Resolves #4139 
Resolves AztecProtocol/dev-rel#148

## Summary\*

- Removes the usage of `aggregation object` while retaining the mention
that recursive proofs are actually aggregation of proofs
- Removes the mention to add the size of public inputs to the proof, as
they are now separate
- Removes some leftover explainer in the `verify_proof` reference

## Additional Context

`noir-examples` is actually not working with this new interface, as I'm
blocked by a weird issue where proofs give me my dear friend
`unreachable`

Will debug that next week with @TomAFrench but I think we're good to
push the docs for now.

---------

Co-authored-by: Cat McGee <helloworld@mcgee.cat>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@signorecello signorecello

Labels
Noir Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(docs): updating docs to match new recursion interfacee noir-lang/noir
1 participant
@signorecello