Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support beta release #13

Merged
merged 3 commits into from
Aug 2, 2023
Merged

support beta release #13

merged 3 commits into from
Aug 2, 2023

Conversation

yiliuTo
Copy link
Contributor

@yiliuTo yiliuTo commented Jul 24, 2023

Purpose

The ASA-AZD integration will go to beta feature soon. This pr is to resolve Azure/azure-dev#2503 to update the template compatible with the beta feature.

Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Others to check

This pr should not be merged until AZD releases ASA as the beta feature, ref https://github.com/Azure/azure-dev/milestone/18

How to test

When AZD 1.2.0 gets released, run the following commands:

mkdir ASA-Samples-Event-Driven-Application
cd ASA-Samples-Event-Driven-Application
azd auth login
azd init --template https://github.com/yiliuTo/ASA-Samples-Event-Driven-Application -b support-beta
azd up

@yiliuTo yiliuTo marked this pull request as ready for review July 24, 2023 06:44
@yiliuTo
Copy link
Contributor Author

yiliuTo commented Jul 24, 2023

Hi @fangjian0423 and @rajeshkamal5050, please help to review this pr, thanks

@rajeshkamal5050
Copy link

LGTM @yiliuTo

Can we also update the template to consume GHA action and Azd as DevContainer features?

@fangjian0423
Copy link
Contributor

hey @rajeshkamal5050

  • For GHA action: we have updated .github/workflows/azure-dev.yml, it means GHA action already support. It that correct?
  • For Devcontainer feature: we have updated .devcontainer/Dockerfile, do you mean we should also support devcontainer.json, or we should support both?

@rajeshkamal5050
Copy link

@fangjian0423 @yiliuTo was referring to use as such for

@vhvb1989
Copy link
Contributor

@fangjian0423 @yiliuTo , I have created this PR: https://github.com/yiliuTo/ASA-Samples-Event-Driven-Application/pull/1/files

It shows the required/missing changes on this PR.
I tried to push the changes directly here, but I had no access :(

There are 3 main changes:

  • Remove the dockerfile
  • Update the devcontainer definition to use the Javascript base image plus the azd-devcontainer-feature (plus the Java-feature)
  • Update the github workflow to use the azd-action and to install java as part of the flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to ASA template - ReadMe, Pipeline Configs etc
5 participants