Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial Phase - 1.5. WebApp signs-in users with local or social identities (B2C) #112

Closed
jmprieur opened this issue Jun 13, 2019 · 3 comments
Assignees
Labels

Comments

@jmprieur
Copy link
Contributor

jmprieur commented Jun 13, 2019

This issue is for a: (mark with an x)

- [ ] bug report -> please search issues before submitting
- [ x ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

It's about adding a phase 1.5 to the tutorial to show how to sign-in users with social identities or local identities with Azure AD B2C

Repro-ing the issue

Go to 1-WebApp-OIDC/1-5-B2C

Expected behavior
A sample is available to explain how to sign-in users to the Web App using Azure AD B2C.

Actual behavior
The directory is empty

Possible Solution

It would be good to:

Note that that sample is a bit old (ASP.NET Core 2.1), and since then, classes such as Azure AD B2C Options, etc ... are available part of ASP.NET Core. (https://github.com/aspnet/AspNetCore/tree/master/src/Azure/AzureAD/Authentication.AzureADB2C.UI/src)

It might be good to:

services.AddAuthentication(AzureADDefaults.AuthenticationScheme)
                ..AddAzureAdB2C(options => Configuration.Bind("Authentication:AzureAdB2C", options))

Maybe have a new method for the OpenIdConnect code which is the same for AzureAD B2C and Azure AD v2.0 (a lot)

Additional context/ Error codes / Screenshots

Good ideas in the B2C sample should be brought back as well in the AAD tutorial (for instance logging ?)

@jmprieur jmprieur added the enhancement New feature or request label Jun 13, 2019
@jmprieur jmprieur mentioned this issue Jun 13, 2019
4 tasks
@jmprieur jmprieur changed the title Tutorial Phase - 1.6. WebApp signs-in users with local or social identities (B2C) Tutorial Phase - 1.5. WebApp signs-in users with local or social identities (B2C) Jun 13, 2019
@jmprieur
Copy link
Contributor Author

@TiagoBrenck
assigning this issue to you. Ping me if this is not clear. The work (given that most of the code is now in ASP.NET core directly) should be minimal.

cc: @kalyankrishna1

@TiagoBrenck
Copy link
Contributor

PR opened: #116

@TiagoBrenck
Copy link
Contributor

This is has been merged already @jmprieur.

@jmprieur jmprieur added Fixed and removed enhancement New feature or request PR in review in progress labels Jul 5, 2019
@jmprieur jmprieur closed this as completed Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants