Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase 1.5 (B2C) in the tutorial #116

Merged
merged 9 commits into from
Jul 3, 2019
Merged

Phase 1.5 (B2C) in the tutorial #116

merged 9 commits into from
Jul 3, 2019

Conversation

TiagoBrenck
Copy link
Contributor

Purpose

Issue: #112
Phase 1.5 to the tutorial to show how to sign-in users with social identities or local identities with Azure AD B2C

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
  • Follow the Readme.md steps to create your Azure B2C

What to Check

Verify that the following are valid

  • Test if you can sign-up then sign-in

Other Information

Tiago Brenck added 3 commits June 13, 2019 10:06
Added B2C basic login functionality
2a8d45c
- Added comments
6bc3f2b 
- Updated README
- Added StartupB2CHelpers on library project
Fixed README
08520ef
@TiagoBrenck TiagoBrenck mentioned this pull request Jun 13, 2019
Closed
@jennyf19
Copy link
Contributor

jennyf19 commented Jun 14, 2019 •
edited by kalyankrishna1
Loading

using Microsoft.AspNetCore.Authentication;

license info? #Resolved

Refers to: 1-WebApp-OIDC/1-5-B2C/Controllers/AuthController.cs:1 in 08520ef. [](commit_id = 08520ef, deletion_comment = False)

jennyf19
jennyf19 reviewed Jun 14, 2019
View reviewed changes
1-WebApp-OIDC/1-5-B2C/Views/Home/Index.cshtml Outdated
</h1>
<p>
This sample shows how to build a .NET Core 2.2 MVC Web app that uses OpenID Connect to sign in users in your organization. It leverages the ASP.NET Core OpenID Connect middleware.
This sample shows how to build a .NET Core 2.2 MVC Web app that uses OpenID Connect to sign in users in B2C. It leverages the ASP.NET Core OpenID Connect middleware.
Copy link
Contributor

@jennyf19 jennyf19 Jun 14, 2019 •
edited by kalyankrishna1
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B2C [](start = 108, length = 3)

they are signing in w/a variety of IdPs...so maybe reword this somehow to include that? #Resolved

jennyf19
jennyf19 approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

kalyankrishna1
kalyankrishna1 reviewed Jun 26, 2019
View reviewed changes
1-WebApp-OIDC/1-5-B2C/README.md

This sample shows how to build a .NET Core 2.2 MVC Web app that uses OpenID Connect to sign in users in **Azure AD B2C**. It assumes you have some familiarity with **Azure AD B2C**. If you'd like to learn all that B2C has to offer, start with our documentation at aka.ms/aadb2c.

![Sign in with Azure AD](ReadmeFiles/sign-in.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sign-in.png [](start = 37, length = 11)

This needs updating, should show Azure AD B2C instead of Azure AD

kalyankrishna1
kalyankrishna1 previously requested changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@kalyankrishna1 kalyankrishna1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

jmprieur
jmprieur reviewed Jun 26, 2019
View reviewed changes
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TiagoBrenck
I'm confused about why you have re-added a couple of things which seem to be in ASP.NET already
Don't hesitate to ping me if you want to discuss this.
cc: @jennyf19 @kalyankrishna1

Microsoft.Identity.Web/B2CStartupHelper.cs Outdated Show resolved Hide resolved
1-WebApp-OIDC/1-5-B2C/Controllers/AuthController.cs Outdated Show resolved Hide resolved
@kalyankrishna1 kalyankrishna1 dismissed their stale review June 28, 2019 19:59

revoking review

kalyankrishna1
kalyankrishna1 approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@kalyankrishna1 kalyankrishna1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

jmprieur
jmprieur approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks @TiagoBrenck

@jmprieur jmprieur merged commit 96c0b77 into tibre/1_5_B2C Jul 3, 2019
@TiagoBrenck TiagoBrenck mentioned this pull request Jul 3, 2019
Merged
@TiagoBrenck TiagoBrenck deleted the tibre/1_5_B2C_Code branch July 4, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalyankrishna1 kalyankrishna1 kalyankrishna1 approved these changes

@jmprieur jmprieur jmprieur approved these changes

@jennyf19 jennyf19 jennyf19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TiagoBrenck @jennyf19 @kalyankrishna1 @jmprieur