Implement SignOut #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
commented
Dec 10, 2018
| @@ -11,28 +11,94 @@ public static class ClaimsPrincipalExtension | |||
| /// <param name="claimsPrincipal">Claims principal</param> | |||
| /// <returns>A string corresponding to an account identifier as defined in <see cref="Microsoft.Identity.Client.AccountId.Identifier"/></returns> | |||
| public static string GetMsalAccountId(this ClaimsPrincipal claimsPrincipal) | |||
| { | |||
There was a problem hiding this comment.
NB
In single tenant scenarios, for a guest account, the ClaimsPrincipal does not contain enough information to compute the account id as the tenant id is the guest tenant (where the gest account was invited), and the oid is the guest oid. We'd need, for the Web scenario to also surface the guest AccountId
jmprieur
commented
Dec 10, 2018
| var account = await app.GetAccountAsync(context.HttpContext.User.GetMsalAccountId()); | ||
|
|
||
| // Workaround for the guest account | ||
| if (account == null) |
There was a problem hiding this comment.
Note what needs to be done for guest accounts in single tenant apps (tenantId is a GUID or domain in appsettings.json and user logs-in with a guest account)
jmprieur
commented
Dec 10, 2018
| IAccount account = await application.GetAccountAsync(accountIdentifier); | ||
|
|
||
| // Special case for guest users as the Guest iod / tenant id are not surfaced. | ||
| if (account == null) |
There was a problem hiding this comment.
Same thing.
Special processing for guest users in single tenant appps.
|
@henrik-me @bgavrilMS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
Follow the readme.
What to Check
Checks that the sample works fine with guest accounts when tenantId is a GUID in appsettings.json
Other Information