Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the PoP handler is capable of validating the 'b' claim #131

Open
mafurman opened this issue Mar 20, 2020 · 0 comments
Open

Make sure the PoP handler is capable of validating the 'b' claim #131

mafurman opened this issue Mar 20, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request P2

Comments

@mafurman
Copy link
Contributor

mafurman commented Mar 20, 2020

Please provide us with the following information:

This issue is for a: (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

The signed http request sent in the PoP sample does not have a 'b' (body) claim, so this claim isn't checked during the validation process.

Expected/desired behavior

We need to make sure that the body extracted by the handler can be properly validated.

Mention any other details that might be useful

We also want to make sure we are using an appropriately sized buffer when reading in the body of the request inside the handler.
NOTE: Validation of the 'b' claim is optional and should not be added to the sample, but we should confirm that it works.

@mafurman mafurman added the enhancement New feature or request label Mar 20, 2020
@mafurman mafurman self-assigned this Mar 20, 2020
@jmprieur jmprieur added the P2 label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2
Projects
None yet
Development

No branches or pull requests

2 participants