Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Helper utility for the samples #185

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

SameerK-MSFT
Copy link
Contributor

Please check PCAHelper.md for explanation

Helper/IPCAHelper.cs Outdated Show resolved Hide resolved
Helper/IPCAHelper.cs Outdated Show resolved Hide resolved
Helper/PCA Helper.md Outdated Show resolved Hide resolved
Helper/PCA Helper.md Outdated Show resolved Hide resolved
Helper/PCA Helper.md Outdated Show resolved Hide resolved
Helper/PCAHelper.cs Outdated Show resolved Hide resolved
Helper/PCAHelper.cs Outdated Show resolved Hide resolved
Helper/PCAHelper.cs Outdated Show resolved Hide resolved
throw new ArgumentException($"Both doSilent and do Interactive cannot be false");
}
}
catch (MsalUiRequiredException)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to catch the exception message here, as they are needed for a claims challenge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used.

Helper/PCAHelper.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great start. Would be nice to align more with the higher-level API we have in Id.Web, as far as method names (ITokenAcquistion, IDownstreamWebApi), to provide consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants