Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge semantic search into main #120

Closed
Tracked by #123
luisquintanilla opened this issue Jul 24, 2023 · 1 comment · Fixed by #164
Closed
Tracked by #123

Merge semantic search into main #120

luisquintanilla opened this issue Jul 24, 2023 · 1 comment · Fixed by #164

Comments

@luisquintanilla
Copy link
Collaborator

luisquintanilla commented Jul 24, 2023

Vector Search is in public preview. Update and merge the vector search branch into main.

https://techcommunity.microsoft.com/t5/azure-ai-services-blog/announcing-vector-search-in-azure-cognitive-search-public/ba-p/3872868

@luisquintanilla
Copy link
Collaborator Author

@LittleLittleCloud for this, let's follow the Python sample guidance.

https://github.com/Azure-Samples/azure-search-openai-demo/blob/c8b8486d68527026b0660a3a75cc4e5e376793c1/app/backend/approaches/chatreadretrieveread.py#L147

We might need to think about how we capture this input in the UI though through a dropdown or toggle.

luisquintanilla pushed a commit that referenced this issue Sep 28, 2023
## Purpose
<!-- Describe the intention of the changes being proposed. What problem
does it solve or functionality does it add? -->
* ...

## Does this introduce a breaking change?
<!-- Mark one with an "x". -->
```
[ ] Yes
[ ] No
```
fix #120

This PR enables option for three search mode
- Text
- Vector
- Hybrid

When `Vector` or `Hybrid` mode is enabled, vector search will be enabled
when searching document from index.

<img width="443" alt="image"
src="https://github.com/Azure-Samples/azure-search-openai-demo-csharp/assets/16876986/6326ce20-bed7-49f5-aae0-e62f2505dcdd">


## Pull Request Type
What kind of change does this Pull Request introduce?

<!-- Please check the one that applies to this PR using "x". -->
```
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:
```

## How to Test
*  Get the code

```
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
```

* Test the code
<!-- Add steps to run the tests suite and/or manually test -->
```
```

## What to Check
Verify that the following are valid
* ...

## Other Information
<!-- Add any other helpful information that may be needed here. -->
IEvangelist pushed a commit to IEvangelist/azure-search-openai-demo-csharp that referenced this issue Dec 5, 2023
## Purpose
<!-- Describe the intention of the changes being proposed. What problem
does it solve or functionality does it add? -->
* ...

## Does this introduce a breaking change?
<!-- Mark one with an "x". -->
```
[ ] Yes
[ ] No
```
fix Azure-Samples#120

This PR enables option for three search mode
- Text
- Vector
- Hybrid

When `Vector` or `Hybrid` mode is enabled, vector search will be enabled
when searching document from index.

<img width="443" alt="image"
src="https://github.com/Azure-Samples/azure-search-openai-demo-csharp/assets/16876986/6326ce20-bed7-49f5-aae0-e62f2505dcdd">


## Pull Request Type
What kind of change does this Pull Request introduce?

<!-- Please check the one that applies to this PR using "x". -->
```
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:
```

## How to Test
*  Get the code

```
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
```

* Test the code
<!-- Add steps to run the tests suite and/or manually test -->
```
```

## What to Check
Verify that the following are valid
* ...

## Other Information
<!-- Add any other helpful information that may be needed here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant