fix: Removing index creation from init of AzureSearchHelper.py (#872)

Azure-Samples · May 13, 2024 · 6b8f125 · 6b8f125
1 parent 828ccd2
commit 6b8f125
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/code/backend/batch/utilities/helpers/azure_search_helper.py b/code/backend/batch/utilities/helpers/azure_search_helper.py
@@ -40,7 +40,6 @@ def __init__(self):
         search_credential = self._search_credential()
         self.search_client = self._create_search_client(search_credential)
         self.search_index_client = self._create_search_index_client(search_credential)
-        self.create_index()
 
     def _search_credential(self):
         if self.env_helper.is_auth_type_keys():

diff --git a/code/tests/functional/tests/backend_api/default/test_conversation_custom.py b/code/tests/functional/tests/backend_api/default/test_conversation_custom.py
@@ -339,7 +339,7 @@ def test_post_makes_correct_call_to_list_search_indexes(
                 "Api-Key": app_config.get("AZURE_SEARCH_KEY"),
             },
             query_string="api-version=2023-10-01-Preview",
-            times=3,
+            times=1,
         ),
     )
 

diff --git a/.../functional/tests/backend_api/sk_orchestrator/test_response_with_search_documents_tool.py b/.../functional/tests/backend_api/sk_orchestrator/test_response_with_search_documents_tool.py
@@ -167,7 +167,7 @@ def test_post_makes_correct_call_to_list_search_index(
                 "Api-Key": app_config.get("AZURE_SEARCH_KEY"),
             },
             query_string="api-version=2023-10-01-Preview",
-            times=3,
+            times=1,
         ),
     )
 

diff --git a/code/tests/utilities/helpers/test_AzureSearchHelper.py b/code/tests/utilities/helpers/test_AzureSearchHelper.py
@@ -245,7 +245,7 @@ def test_creates_search_index_if_not_exists(
     )
 
     # when
-    AzureSearchHelper()
+    AzureSearchHelper().get_search_client()
 
     # then
     search_index_client_mock.return_value.create_index.assert_called_once_with(
@@ -265,7 +265,8 @@ def test_does_not_create_search_index_if_it_exists(
     ]
 
     # when
-    AzureSearchHelper()
+    azure_search_helper = AzureSearchHelper()
+    azure_search_helper.get_search_client()
 
     # then
     search_index_client_mock.return_value.create_index.assert_not_called()
@@ -283,7 +284,7 @@ def test_propogates_exceptions_when_creating_search_index(
 
     # when
     with pytest.raises(Exception) as exc_info:
-        AzureSearchHelper()
+        AzureSearchHelper().get_search_client()
 
     # then
     assert exc_info.value == expected_exception