Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Bug - 4658] Updated stop sequence to empty string in Bicep #1070

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

Prasanjeet-Microsoft
Copy link
Contributor

Purpose

Changed the default value from "\n" to empty in Bicep to get the complete responses

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Run the app and check whether we are getting complete response for every question

Copy link

github-actions bot commented Jun 20, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL257957377% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
288 0 💤 0 ❌ 0 🔥 37.979s ⏱️

@ross-p-smith
Copy link
Collaborator

The title of your PR is used in the Release Notes - are you able to update it so that it is a meaningful sentence (I think you have this in the description)

@Prasanjeet-Microsoft Prasanjeet-Microsoft changed the title fix: PSL-BUG-4658 fix: Updated stop sequence to empty string Jun 20, 2024
@Prasanjeet-Microsoft
Copy link
Contributor Author

@ross-p-smith Done

@cecheta cecheta self-requested a review June 20, 2024 13:28
Copy link
Collaborator

@cecheta cecheta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you make sure that main.json also gets updated

az bicep build -f infra/main.bicep

@Roopan-Microsoft
Copy link
Contributor

Please could you make sure that main.json also gets updated

az bicep build -f infra/main.bicep

Yes @cecheta - Its updated. Please review and approve once.

@Roopan-Microsoft Roopan-Microsoft changed the title fix: Updated stop sequence to empty string fix: [Bug - 4658] Updated stop sequence to empty string in Bicep Jun 21, 2024
@Roopan-Microsoft Roopan-Microsoft added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit 016489b Jun 21, 2024
12 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the roopan/BUG-4658 branch June 21, 2024 10:30
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants