Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use relative path for ConversationFlow import so that shared code works in all applications #963

Merged
merged 3 commits into from
May 23, 2024
Merged

fix: Use relative path for ConversationFlow import so that shared code works in all applications #963

merged 3 commits into from
May 23, 2024

Conversation

gaurarpit
Copy link
Collaborator

@gaurarpit gaurarpit commented May 22, 2024 •
edited
Loading

Purpose

Does this introduce a breaking change?

  • Yes
  • No

@gaurarpit gaurarpit changed the title fix: fix the relative import instead of absolute inside env_helper. fix: [WIP] fix the relative import instead of absolute inside env_helper. May 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/helpers
   env_helper.py137695%237–239, 255–257
TOTAL247356277% 

Tests Skipped Failures Errors Time
273 0 💤 0 ❌ 0 🔥 34.809s ⏱️

@liammoat liammoat changed the title fix: [WIP] fix the relative import instead of absolute inside env_helper. fix: fix the relative import instead of absolute inside env_helper. May 22, 2024
@liammoat liammoat changed the title fix: fix the relative import instead of absolute inside env_helper. fix: fix the relative import instead of absolute inside env_helper May 22, 2024
@liammoat liammoat marked this pull request as ready for review May 22, 2024 15:40
@ross-p-smith
Copy link
Collaborator

Sorry, what story is this linked with?

@gaurarpit
Copy link
Collaborator Author

Sorry, what story is this linked with?

added details in the description section:
Comment from : #905 (comment)

ross-p-smith
ross-p-smith approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@ross-p-smith ross-p-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix the title of the PR before you merge please' maybe

"fix: Use relative path for ConversationFlow import so that shared code works in all applications"

@gaurarpit gaurarpit changed the title fix: fix the relative import instead of absolute inside env_helper fix: Use relative path for ConversationFlow import so that shared code works in all applications May 23, 2024
@gaurarpit gaurarpit added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit a9ce0bd May 23, 2024
9 checks passed
@gaurarpit gaurarpit deleted the arpit/bugfix/non-absolute-import branch May 23, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ross-p-smith ross-p-smith ross-p-smith approved these changes

@cecheta cecheta cecheta approved these changes

Assignees

@liammoat liammoat

@gaurarpit gaurarpit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement endpoint switch to custom
4 participants
@gaurarpit @ross-p-smith @cecheta @liammoat