-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add conventional commit preset #968
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ross-p-smith
previously approved these changes
May 23, 2024
cecheta
previously approved these changes
May 23, 2024
gaurarpit
previously approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. o ..
o . o o.o
...oo
__[]__
__|_o_o_o\__
\""""""""""/
\. .. . /
^^^^^^^^^^^^^^^^^^^^
8f756e2
cecheta
approved these changes
May 23, 2024
🎉 This PR is included in version 1.2.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The
semantic-release/commit-analyzer
is used in our release Action to parse our commit history and figure out the version for the release. By default, it does not detect the!
syntax which marks a PR as a breaking change. This meant that in our first run of the updated Action, it did not correctly bump the major version despite including a breaking change: https://github.com/Azure-Samples/chat-with-your-data-solution-accelerator/releases/tag/v1.2.0This issue comment describes how using a preset we can use the exclamation mark functionality: semantic-release/semantic-release#2339 (comment).
This PR includes that change, and has been tested using my personal test repository. Note that, when merged, it will not bump the major version since the previous breaking change was considered in an earlier release. It should however apply to any future breaking changes.
Thank you to @cecheta for finding the thread which included the solution used here.
Does this introduce a breaking change?