-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JAVA Speech SDK 1.16 crashes if there is no connection #997
Comments
@matecode thanks for reporting this! Can you please check to see if this also happens with version 1.15 or earlier? |
@dargilco Sorry, i forgot to mention: It does not happen in version 1.15 |
@matecode, thanks for confirming. Let me follow up on it and I’ll post an update here as soon as I have it. |
Okay did some more investigation and it is a bug in Speech SDK after all. This is a regression in Speech SDK version 1.12, as I can run the Android sample with version 1.11 and get the cancelation event as expected (when I use wrong Speech Key). When I do the same with version 1.12, there is a crash. I do not get a cancelation event. |
I checked version 1.15 and 1.16, and in my own project which is different to the sample i have a crash with 1.16, but not with 1.15 |
@matecode what is the Android device you are using and what Android version does it run? |
@dargilco I tested with Android10 on a Nokia 7.2 and also with Android11 on a SamsungS20+ this is the logcat output from the VirtualAssistantClient Sample on the S20+:
|
Thanks! |
@matecode The crash in Speech SDK was fixed and will be available in the next public release. Thank you again for reporting this! I also noticed that the Virtual Assistant sample code blindly tries to re-create the DialogServiceConnector session on every cancelation event, including no network connection or bad speech keys, which is probably not a good idea as this just results in an infinite loop of re-creating the session. It should simply display the error and stop. I'll file a bug on the Bot-Framework solution team to fix the sample code. I will close this issue. |
With version 1.16 the java library crashes if there is no network connection. i'm using it on an android device.
Reproduction:
Check out Sample Project and change directlinespeech modules build.gradle to
implementation 'com.microsoft.cognitiveservices.speech:client-sdk:1.16.0'
Run without any network connection on device
Logcat:
A/libc: Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0 in tid 24001 (Thread-4), pid 23963 (irtualassistant)
The text was updated successfully, but these errors were encountered: