Broken repo link on 'Before running the sample for the first time' #2
Comments
|
Sorry about that. They have been since migrated to this location. https://github.com/Azure-Samples/communication-services-web-calling-hero I'll be working to fix up the documentation. Thanks for raising this issue |
|
Should be solved with this 14a0cd3 |
ddematheu2
pushed a commit
that referenced
this issue
Dec 5, 2020
* adding deploy button * add raw url to deploy file * forgot closing brace * adding default random names for plan + acs resource name * testing out random variables * addiung serviceName variable * pushing changes * test changes * removing unused parameters * testing * moving parameters into variables * fixing casing * copying key * update version of communications when copying key * validate if copy was bad * trying reference usage isntead * accessing keys through properties * simplifying script * removing configuration value * reverting changes * updating to get keys * TEST * Add or update the App Service deployment workflow configuration from Azure Portal. * modifying location of button * trying out suggested changes * updating sourceControls resource * 1 * putting back in appsettings change * adding in source controls sub resource * removing concat * trying out how to deploy azure app service * trying out language tempalte * forcing installing react-scripts for start + build * Add or update the App Service deployment workflow configuration from Azure Portal. * moving typescript to build dependencies * adding typescript * removing github flows * moving prettier to depednencies from dev * trying to deploy source from github * moving back to original deploy script * seeing if having a correct branch will help * updating node version in app service * trying to consolidate azure deploy script * Update README.md * updating azure deploy script in branch * updating readme to use deploy script * putting in correct encoded url * trying to make appsettings a dependency of sourcecontrolws * fixing appsettings resource id target * adding in app name parameter * fixing web app name * trying out using webdeploy * trying to use exactly what is used in the samples * removing extra msdeploy * pushing two new deploy files * adding two buttons for both scripts * fixing webdeploy deploy script * pushing simplified readme changes * moving deploy button higher up * pushing up some ARm changes * fixing azuredeploy filename * Update README.md * setting up the resource group for the developer as well * removing dependencies on anything from resource group * reverting back changes Co-authored-by: Alex Kwan (ONENOTE) <alkwa@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is for a: (mark with an
x)Minimal steps to reproduce
When you follow the steps on the 'Before running the sample for the first time' on:
#2. git clone https://github.com/Azure/Communication.git
That git repo, no longer contains the calling samples as of Oct 22, 2020.
Any log messages given by the failure
No error message, just the calling samples are missing.
Expected/desired behavior
I expect the calling sample to be included when I clone that repo
OS and Version?
not applicable
Versions
not applicable
Mention any other details that might be useful
The text was updated successfully, but these errors were encountered: