Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add muteOthers capability to Call and RemoteParticipant #235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

allchiang-msft
Copy link
Contributor

@allchiang-msft allchiang-msft commented Jul 5, 2024

Purpose

  • Blocks Mute All button from appearing if user does not have the capability to muteOthers
  • Logs console error from clicking on mute icon of remote participant if user does not have the capability to muteOthers

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code
  1. Login in 2 tabs as ACS users
  2. Create a Room with 1 user as Presenter, 1 user as Attendee

What to Check

Verify that the following are valid

  1. Presenter has Mute All button, can mute all successfully. Presenter can mute specific remote participant successfully.
  2. Attendee does not have Mute All button. Attendee cannot mute specific remote participant.

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants