Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HackTogether: Share Property to More social media #255

Closed
1 task done
john0isaac opened this issue Aug 7, 2023 · 24 comments · Fixed by #300
Closed
1 task done

HackTogether: Share Property to More social media #255

john0isaac opened this issue Aug 7, 2023 · 24 comments · Fixed by #300
Assignees
Labels
Hack-together:accepted Accepted after triage and ready for to be done Hack-together

Comments

@john0isaac
Copy link
Contributor

Are you accessing the project from the GitHub Codespaces?

  • Yes, I am using GitHub Codespaces.

Describe the bug
When you try to share a property, it directs you to X social media platform.

To Reproduce

  1. Open the Portal
  2. Click on any listing
  3. Click the share Icon

Expected behavior
Show a pop up or bar with multiple platforms to select from. (e.g. Facebook, LinkedIn, WhatsApp, Messenger, Instagram, and Telegram)
User selects the desired social media to share the property to.

Screenshots
Listing Page Share Property
image

X Platform Sign in Page
image

@anfibiacreativa
Copy link
Member

Thanks for reporting! We look forward to your PR!

@anfibiacreativa anfibiacreativa added Hack-together:accepted Accepted after triage and ready for to be done and removed status: needs triage labels Aug 9, 2023
@john0isaac
Copy link
Contributor Author

@anfibiacreativa thank you!!

@juliamuiruri4
Copy link
Collaborator

Hey @john0isaac - There is a participant interested in working on this issue. @GmausDev

Are you already working on this, or is there a possibility to team up with him?

@john0isaac
Copy link
Contributor Author

@juliamuiruri4 Definitely yes, we can team up!

@GmausDev
Copy link
Contributor

So @john0isaac How can we start?¿

@john0isaac
Copy link
Contributor Author

@GmausDev Let's start by dividing the work into two steps:
Step 1: Create a pop-up menu to choose the desired social media platform from when anyone clicks on the share icon.
Step 2: Add other social media platforms to the pop-up menu.

Unfortunately, we can't both work on the menu at the same time as step 1 is a blocker for step 2 so, please choose a step to start working on and I will continue after you.

Note:
If you choose step 1 I will be waiting for you to finish it.
If you choose step 2 you will have to wait for me to finish step 1.

@GmausDev
Copy link
Contributor

Okay !
@john0isaac
Yep I was thinking the same , create a simple pop up and then add a stylish link tree.

My main expertise its back end and not in jss or tss , Take the step 1 and I´ll take the 2 I thinks its be more easier.

What do you think?

@john0isaac
Copy link
Contributor Author

@GmausDev Okay I will start working on it.
When I finish I will let you know here.

@bilalbyte
Copy link

Hey can I join you guys, I am a beginner and want to contribute, @GmausDev @john0isaac

@GmausDev
Copy link
Contributor

Also , we can use teams or whatever. Btw , I´ll be on it ^^.

@bilalbyte Maybe it´s not big enough but this hackathon its about contribute and colaborate! I had no problem but we need to figure out how to.

So @john0isaac what do you think?

@bilalbyte
Copy link

I will be so grateful @GmausDev , Teams is a good option

@GmausDev
Copy link
Contributor

Also im with another bug, if @john0isaac and @juliamuiruri4 I can step out and you can take the second phase from john repo.

I had no problem and if you feel comfortable with this issue my part is yours.

If @juliamuiruri4 its agree with this assign @bilalbyte to this issue , pls.

Thanks!

@john0isaac
Copy link
Contributor Author

@GmausDev that's fine I can work with @bilalbyte.
@bilalbyte glad to work with you! 🤝🏼

@bilalbyte you can work on the same thing @GmausDev was going to work on as it will be an easy part and I can guide you through it.

@juliamuiruri4 please, assign @bilalbyte to this issue in addition to me and remove @GmausDev.

@GmausDev GmausDev removed their assignment Aug 19, 2023
@GmausDev
Copy link
Contributor

@john0isaac Removed :P. @bilalbyte Have fun!

@Blackie360
Copy link

can you guys organize a google meet to help me start I don't how to start

@bilalbyte
Copy link

Thank you @john0isaac

@john0isaac
Copy link
Contributor Author

@Blackie360 there are many online live sessions on Microsoft Reactor to guide you through your journey!
check the posting here! => #236
Also, if you are looking for something to help you get started I would recommend checking this => #236 (comment)
Specifically, this video that guides you on how to get started => https://youtu.be/cAAE2LwwZEQ

@john0isaac
Copy link
Contributor Author

Hey @bilalbyte,
I created a pull request that will close this issue.
I have set up everything for you to learn from and just copy and paste to add more platforms.

Once my pull request is merged I will include instructions for you to complete working from where I stopped!

@Kagirim
Copy link

Kagirim commented Aug 21, 2023

Hello guys, who is working on what at the moment, are there specific places that still need some hands?

@Kagirim
Copy link

Kagirim commented Aug 21, 2023

Thanks! that will be of massive help as im kind of lost about how to collaborate on this issue

@bilalbyte
Copy link

Hey @bilalbyte,
I created a pull request that will close this issue.
I have set up everything for you to learn from and just copy and paste to add more platforms.

Once my pull request is merged I will include instructions for you to complete working from where I stopped!

Sure, I'll be waiting for that

@john0isaac
Copy link
Contributor Author

john0isaac commented Aug 21, 2023

Hello guys, who is working on what at the moment, are there specific places that still need some hands?

@Kagirim Great question!
You can check out this comment to know the answer.
#236 (comment)
image

to know which issues are available to work on check the issues tab.
https://github.com/Azure-Samples/contoso-real-estate/issues

@Kagirim
Copy link

Kagirim commented Aug 22, 2023

Hello guys, who is working on what at the moment, are there specific places that still need some hands?

@Kagirim Great question! You can check out this comment to know the answer. #236 (comment) image

to know which issues are available to work on check the issues tab. https://github.com/Azure-Samples/contoso-real-estate/issues

Thank you @john0isaac i was referring to the development progress on this issue on the share button. I'd like to know which section has not been handled yet.

@john0isaac
Copy link
Contributor Author

john0isaac commented Aug 22, 2023

@Kagirim Follow this pull request -> #300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hack-together:accepted Accepted after triage and ready for to be done Hack-together
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants