feat: Create sharing menu #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john0isaac
requested review from
anfibiacreativa,
manekinekko and
sinedied
as code owners
anfibiacreativa
requested changes
Aug 22, 2023
anfibiacreativa
added
Hack-together
Hack-together:awaiting-feedback
…' into create-sharing-menu
I couldn't figure out the part where you mentioned creating a global object for the sharing URL I did it inside the function as I didn't know if there was a file to create the global variables in or if should I just have included them after the imports in the same file. As for the part where you recommend using the ternary operator I think it will get more complicated as we add more social media platforms so, I wouldn't recommend it although it's a beautiful idea if we only had two platforms. Thanks again for the amazing feedback. |
1 task
sinedied
previously approved these changes
Aug 29, 2023
Co-authored-by: Yohan Lasorsa <noda@free.fr>
|
@sinedied I approved your changes. |
anfibiacreativa
approved these changes
Aug 31, 2023
anfibiacreativa
added
Hack-together:accepted
anfibiacreativa
approved these changes
Aug 31, 2023
devin-ai-integration bot
pushed a commit
to altsang/contoso-real-estate
that referenced
this pull request
May 14, 2024
* Import material menu * Replace share button with menu * link three menu items to share function * feat: setup share to different platforms * fix: twitter hashtags * feat: configure facebook sharing * style: add spaces around imports * style: add spaces around if * feat: check platform exists * refactor: destructure sharing url varianle * Update packages/portal/src/app/rentalpage/rentalpage.component.html Co-authored-by: Yohan Lasorsa <noda@free.fr> --------- Co-authored-by: Yohan Lasorsa <noda@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #255
While working on this I found a new issue the hashtags weren't added correctly to the twitter sharing link.
I fixed this issue now if you try to share on twitter the hashtags will appear.
Adding more platforms now will be much easier as it's only a copy-and-paste process. (see this)
