Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hack-together] Sometimes Value of discounted Price is 0 #280

Closed
1 task
Tanmai2002 opened this issue Aug 16, 2023 · 3 comments · Fixed by #281
Closed
1 task

[Hack-together] Sometimes Value of discounted Price is 0 #280

Tanmai2002 opened this issue Aug 16, 2023 · 3 comments · Fixed by #281
Assignees
@juliamuiruri4
Labels
Hack-together:accepted Accepted after triage and ready for to be done Hack-together

Comments

@Tanmai2002
Copy link
Contributor

Are you accessing the project from the GitHub Codespaces?

  • No, I am running the project on my local machine (I will fill in the OS section below)
  • [ X] Yes, I am using GitHub Codespaces.

Note: The project is optimized to run on Codespaces. We welcome contributions to enhance it for cross-platform local development, but it's not something we will prioritize right now. Thank you!

Describe the bug
When I Hard refresh or use
/listing/{number}/modern-apartment-close-to-the-metro-station

To Reproduce
Steps to reproduce the behavior:

  1. Open any Listing
  2. Select the url: example http://127.0.0.1:4280/listing/3/great-home-for-entertaining
  3. Copy it to new tab and paste.
  4. See error

Expected behavior
Correct Value of Discounted Price

Screenshots
image

OS (please complete the following information):

  • OS:
  • OS Version:
  • npm version:
  • Node.js version:
  • output of azd version:

Additional context
This may be mostly as MonthlyDiscountedRent is Calculated based on this.monthlyRentPrice() rather than rent fetched from listing. Thus all other values are intact but not the MonthlyDiscountedRent.
@Tanmai2002
Copy link
Contributor Author

This is the issue as this.monthlyRentPrice is set after setting value for rentPriceWithDiscount

Tanmai2002 added a commit to Tanmai2002/contoso-real-estate that referenced this issue Aug 16, 2023
@Tanmai2002
fix: fixed issue Azure-Samples#280 the value might was set after use …
f5059f1 
…leading to inconsistency
@anfibiacreativa
Copy link
Member

Hi, thanks for reporting! Looking forward to your fix!

@anfibiacreativa anfibiacreativa added Hack-together:accepted Accepted after triage and ready for to be done and removed status: needs triage labels Aug 17, 2023
@Tanmai2002
Copy link
Contributor Author

@anfibiacreativa I Have created a Pull Request. Kindly Check.

Tanmai2002 added a commit to Tanmai2002/contoso-real-estate that referenced this issue Aug 17, 2023
@Tanmai2002
fix: fixed Azure-Samples#280 updated value to get directly from listing
14e9f8a
@Tanmai2002 Tanmai2002 mentioned this issue Aug 17, 2023
Merged
anfibiacreativa added a commit that referenced this issue Aug 23, 2023
@Tanmai2002 @anfibiacreativa
fix: fix #280 updated value to get directly from listing (#281)
0d1f0e8 
Co-authored-by: Natalia Venditto <nataliafrontend@gmail.com>
devin-ai-integration bot pushed a commit to altsang/contoso-real-estate that referenced this issue May 14, 2024
@Tanmai2002 @anfibiacreativa
fix: fix Azure-Samples#280 updated value to get directly from listing (…
283c15a 
…Azure-Samples#281)

Co-authored-by: Natalia Venditto <nataliafrontend@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliamuiruri4 juliamuiruri4

Labels
Hack-together:accepted Accepted after triage and ready for to be done Hack-together
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fixed #280 updated value to get directly from listing Tanmai2002/contoso-real-estate
3 participants
@anfibiacreativa @juliamuiruri4 @Tanmai2002