Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(strip): fix major deps issues #416

Merged
merged 2 commits into from Jan 11, 2024
Merged

fix(strip): fix major deps issues #416

merged 2 commits into from Jan 11, 2024

Conversation

manekinekko
Copy link
Collaborator

@manekinekko manekinekko commented Dec 6, 2023 •
edited

All services are working again!

Closes #386

image

image

@manekinekko manekinekko self-assigned this Dec 6, 2023
@xingsy97
Copy link
Contributor

Hi @manekinekko , I encountered deployment issues using this PR, could you please take a look?

Reproduce Steps

  1. Create a code space using the button in the beginning of README

  2. Run npm install, npm run start

  3. Then I see many error logs. I found the issue is triggered in the command npm run start:services". Due to the max length limit of VSCODE terminal, I execute npm run start:services > log.txt` to save the complete log attached here

  4. For I failed to deploy the local version, I deploy it to Azure following accroding to here
    The online Azure version seems working well.

  5. After deploying it to Azure, I run npm run start again in Codespace. The error log in Step 3 disappeared. However, the API service doesn't work.

  • Visit the "Forwarded Address" of "Portal App", F12 open developer tool, all api requests return 404.
  • In codespace, run wget "http://localhost:7071/api/listings. It also returns 404

@anfibiacreativa anfibiacreativa changed the base branch from main to develop December 27, 2023 15:48
@manekinekko
Copy link
Collaborator Author

I am working in fixing these conflicts.

@manekinekko manekinekko merged commit 3bfe9c7 into develop Jan 11, 2024
@manekinekko manekinekko deleted the fix-issue-386 branch January 11, 2024 16:08
devin-ai-integration bot pushed a commit to altsang/contoso-real-estate that referenced this pull request May 14, 2024
@manekinekko
fix(strip): fix major deps issues (Azure-Samples#416)
39bce96 
* fix(strip): fix major deps issues

Closes Azure-Samples#386

* chore: exclude legacy api from workspace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinedied sinedied Awaiting requested review from sinedied

@anfibiacreativa anfibiacreativa Awaiting requested review from anfibiacreativa

Assignees

@manekinekko manekinekko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Chore] npm install issues
3 participants
@manekinekko @xingsy97 @anfibiacreativa