Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Don't Truncate Failures - Only Truncate if Response is 2XX #62

Merged
merged 1 commit into from Feb 20, 2019
Merged

Don't Truncate Failures - Only Truncate if Response is 2XX #62

merged 1 commit into from Feb 20, 2019

Conversation

JosephPaulAntonetti
Copy link
Contributor

Purpose

Please describe the intention of the changes being proposed. What problem does it solve or functionality does it add?

This prevents failures (400, 500 level status codes) from being truncated by the console, allowing the user to properly debug the issue.

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] New sample or new feature within a sample
[ ] Code style update (formatting, naming)
[ ] Refactoring (no functional changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Test By

Please describe how you tested

Dotnet ran

alinamstanciu
alinamstanciu approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@alinamstanciu alinamstanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JosephPaulAntonetti JosephPaulAntonetti merged commit a5ce27e into Azure-Samples:master Feb 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alinamstanciu alinamstanciu alinamstanciu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JosephPaulAntonetti @alinamstanciu