Rename ADU *device_information, send update result details #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ADU documentation refers to the device basic information as "device properties", not "device information", so this change renames the structures and variables to match that naming. Also the ADU sample gets an improvement to send a description for the update result details, as well as an user-defined extended result code.
danewalton
approved these changes
Jul 11, 2022
demos/projects/ESPRESSIF/adu/main/azure_iot_freertos_esp32_pnp_model.h
Outdated
Show resolved
Hide resolved
demos/projects/ESPRESSIF/adu/main/azure_iot_freertos_esp32_pnp_model.h
Outdated
Show resolved
Hide resolved
danewalton
reviewed
Jul 12, 2022
libs/azure-iot-middleware-freertos/source/azure_iot_adu_client.c
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The ADU documentation refers to the device basic information as
"device properties", not "device information", so this change renames
the structures and variables to match that naming.
Also the ADU sample gets an improvement to send a description for the
update result details, as well as an user-defined extended result code.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?