Skip to content

Commit

Permalink
Hotfix 20230825 (#63)
Browse files Browse the repository at this point in the history
* Fixed bug where location was hardcoded
* Minor code security improvements
  • Loading branch information
rukasakurai committed Aug 25, 2023
1 parent afecf91 commit 19d3ef3
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ azd up
```
接続先:Virtual MachineのパブリックIPアドレス
ユーザ名:azureuser
パスワード:Admin#123456#
```

6. Virtual Machine内での中でブラウザを開き、App Serviceの `既定のドメイン` へのアクセスが可能なことを確認してください。
Expand Down
1 change: 0 additions & 1 deletion 5.internal-document-search/infra/core/db/cosmosdb.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ resource cosmosDbContainer 'Microsoft.DocumentDB/databaseAccounts/sqlDatabases/c
output id string = cosmosDbAccount.id
output name string = cosmosDbAccount.name
output endpoint string = cosmosDbAccount.properties.documentEndpoint
output key string = cosmosDbAccount.listKeys().primaryMasterKey
output databaseName string = cosmosDbDatabase.name
output containerName string = cosmosDbContainer.name
output accountName string = cosmosDbAccount.name
3 changes: 2 additions & 1 deletion 5.internal-document-search/infra/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ param subnetAddressPrefix3 string = '10.0.2.0/24'
param privateEndpointLocation string = location

param vmLoginName string = 'azureuser'
param vmLoginPassword string = 'Admin#123456#'
@secure()
param vmLoginPassword string

@description('Id of the user or app to assign application roles')
param principalId string = ''
Expand Down
2 changes: 1 addition & 1 deletion 5.internal-document-search/infra/main.parameters.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"value": "${AZURE_ENV_NAME}"
},
"location": {
"value": "eastus"
"value": "${AZURE_LOCATION}"
},
"resourceGroupName": {
"value": "${AZURE_RESOURCE_GROUP}"
Expand Down

0 comments on commit 19d3ef3

Please sign in to comment.