Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update function version, app insigth and some fixes #1

Merged
merged 7 commits into from
Nov 15, 2023

Conversation

rfernandezdo
Copy link

Purpose

Update function version, app insigth and some fixes

Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Follow Readme

What to Check

Check the same functionality that the application had previously

Other Information

@jlichwa
Copy link
Contributor

jlichwa commented Oct 14, 2022

@rfernandezdo were you able to test it, if updates work for the tutorial: https://learn.microsoft.com/en-us/azure/key-vault/secrets/tutorial-rotation-dual?tabs=azure-cli

@rfernandezdo
Copy link
Author

rfernandezdo commented Oct 17, 2022

Yes @jlichwa, I tested it following the tutorial that you mentioned, but if there is something new, you need to have a pre-created Log Analytics Workspace for App Insight creation

@rfernandezdo
Copy link
Author

@jlichwa

Do you need something more ?

@jlichwa jlichwa merged commit 405ecf0 into Azure-Samples:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants